Skip to content

fix: imu scale estimation covariance limit for stability#12562

Open
SergioReyesSan wants to merge 1 commit intoautowarefoundation:mainfrom
SergioReyesSan:fix/covariance_limit
Open

fix: imu scale estimation covariance limit for stability#12562
SergioReyesSan wants to merge 1 commit intoautowarefoundation:mainfrom
SergioReyesSan:fix/covariance_limit

Conversation

@SergioReyesSan
Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue in the IMU scale estimation where the covariance matrix (specifically non-diagonal terms) would increase significantly when the vehicle is stationary or moving straight/ slow turning for extended periods. This growth caused instability in scale estimation and triggered MRM.

Parent Issue:

  • Link

How was this PR tested?

The fix was validated using Rosbags directly from the vehicle, with prolonged, slow turns causing no updates to the imu scale estimate. Furthermore, a Rosbag containing an NDT pose anomaly (which previously caused system instability due to high accumulated covariance) was tested; the system now remains stable after the fix.

decay coefficient and threshold to estimate scale parameters, also changed to increase scale estimation stability.

No needed changes on this version of Autoware launch, since it uses the default values.

Related links

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Sergio Reyes Sanchez <sergioreyes.sanchez@tier4.jp>
@github-actions github-actions Bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SergioReyesSan SergioReyesSan added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 8, 2026
@SergioReyesSan SergioReyesSan changed the title Fix: imu scale estimation covariance limit for stability fix: imu scale estimation covariance limit for stability May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.04%. Comparing base (54af299) to head (f536089).

Files with missing lines Patch % Lines
...autoware_imu_corrector/src/gyro_bias_estimator.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12562       +/-   ##
===========================================
- Coverage   18.64%   18.04%    -0.60%     
===========================================
  Files        1918        5     -1913     
  Lines      131362      615   -130747     
  Branches    44502      257    -44245     
===========================================
- Hits        24489      111    -24378     
+ Misses      86760      406    -86354     
+ Partials    20113       98    -20015     
Flag Coverage Δ
daily ?
full-suite 18.04% <0.00%> (-0.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant