fix: imu scale estimation covariance limit for stability#12562
Open
SergioReyesSan wants to merge 1 commit intoautowarefoundation:mainfrom
Open
fix: imu scale estimation covariance limit for stability#12562SergioReyesSan wants to merge 1 commit intoautowarefoundation:mainfrom
SergioReyesSan wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Sergio Reyes Sanchez <sergioreyes.sanchez@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12562 +/- ##
===========================================
- Coverage 18.64% 18.04% -0.60%
===========================================
Files 1918 5 -1913
Lines 131362 615 -130747
Branches 44502 257 -44245
===========================================
- Hits 24489 111 -24378
+ Misses 86760 406 -86354
+ Partials 20113 98 -20015
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the IMU scale estimation where the covariance matrix (specifically non-diagonal terms) would increase significantly when the vehicle is stationary or moving straight/ slow turning for extended periods. This growth caused instability in scale estimation and triggered MRM.
Parent Issue:
How was this PR tested?
The fix was validated using Rosbags directly from the vehicle, with prolonged, slow turns causing no updates to the imu scale estimate. Furthermore, a Rosbag containing an NDT pose anomaly (which previously caused system instability due to high accumulated covariance) was tested; the system now remains stable after the fix.
decay coefficient and threshold to estimate scale parameters, also changed to increase scale estimation stability.
No needed changes on this version of Autoware launch, since it uses the default values.
Related links
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.