Disallow slow sorting #3981
Merged
Disallow slow sorting #3981
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
joshua-kim,
rrazvan1 and
maru-ava
as code owners
joshua-kim
approved these changes
May 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR replaces reflection-based sorting calls with the generic, faster slices.Sort and updates the linter to forbid the old patterns.
- Swap out
sort.Strings/sort.Sliceforslices.Sortin tests - Update imports accordingly
- Add a forbidigo rule to disallow
sort.Slice/sort.Strings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| x/merkledb/view_iterator_test.go | Replaced sort.Strings with slices.Sort and updated imports |
| vms/platformvm/validator_set_property_test.go | Replaced sort.Slice call with slices.Sort and updated imports |
| .golangci.yml | Added forbidigo exclusion for sort.Slice/sort.Strings |
yacovm
approved these changes
May 28, 2025
maru-ava
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
sort.Sliceis an old method of sorting that relies on reflection. Theslices.Sortmethod is generic and runs faster.How this works
This doesn't disallow
sortentirely, as there are still some usages of thesort.Interfacewhich are a bit more complex to change... Although we should probably change those as well eventually.How this was tested
CI
Need to be documented in RELEASES.md?
No.