Skip to content

Assertions return boolean #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Assertions return boolean #2584

wants to merge 14 commits into from

Conversation

adiSuper94
Copy link
Contributor

Changes to address #2455 .
Assertion return boolean.

@adiSuper94
Copy link
Contributor Author

@novemberborn if the way I have edited the assertion testcases are fine, I'll make the changes to all cases.

@novemberborn
Copy link
Member

if the way I have edited the assertion testcases are fine, I'll make the changes to all cases.

Does this include the changes made in #2564? Would you be able to edit the commits here so that de16258 is included, followed by your changes? It'll make it easier to see what you've addressed from #2564 and it retains the credit.

novemberborn and others added 13 commits September 19, 2020 22:03
@novemberborn @adiSuper94
Test compatibility with TypeScript 4.0
9ceb562
@macarie @novemberborn @adiSuper94
Experimentally configure module formats for test files
4358714 
Fixes avajs#2345.

Co-authored-by: Mark Wubben <[email protected]>
@novemberborn @adiSuper94
Update dependencies
65de5fe 
* Update dev dependencies

* Update XO

* Update dependencies

* Rebuild lockfile
@novemberborn @adiSuper94
3.12.0
1e064b0
@novemberborn @adiSuper94
Revert advanced IPC
e0aa9c6 
* Revert "Don't use global setImmediate"

This reverts commit ea66e64.

* Revert "Use advanced serialization (when available) for worker communication"

This reverts commit 0f879f4.
@novemberborn @adiSuper94
3.12.1
ce3797b
@erights @adiSuper94
Fix typo in VSCode recipe
1ab3cfb
@jonathansamines @adiSuper94
Update enzyme recipe to work with latest enzyme
3b4e3de
@novemberborn @adiSuper94
Sanitize timers.js positions in reporter logs
13ac99c
@tymfear @adiSuper94
Make t.passed usable in tests and teardown functions
67acbea
@jonathansamines @adiSuper94
Convert integration tests to be self-hosted
aa06d33 
* Reconfigure xo and eslint to purposely ignore bad configurations
* Rewrite expectations to use snapshots
* Fix trailing symbols strip functionality for output cleanup
* Use posix path relative resolution on tests filename snapshots
* Normalize posix paths on test snapshots
@JSimoni42 @adiSuper94
Experimentally disable null expectations for throws assertions
13469c8
@adiSuper94
Assertions return boolean
7acbfce
@adiSuper94 adiSuper94 force-pushed the feat/asserts-return-bool branch from 4ac6b65 to 7acbfce Compare September 19, 2020 17:40
@adiSuper94
Copy link
Contributor Author

adiSuper94 commented Sep 19, 2020 •
edited
Loading

@novemberborn rebaseing de16258 have updated all the commits after that too as a side effect.
Closing this pull request.
Please check this one out #2586

@adiSuper94 adiSuper94 closed this Sep 19, 2020
@adiSuper94
Copy link
Contributor Author

if the way I have edited the assertion testcases are fine, I'll make the changes to all cases.

Does this include the changes made in #2564? Would you be able to edit the commits here so that de16258 is included, followed by your changes? It'll make it easier to see what you've addressed from #2564 and it retains the credit.

I didn't start working on top of [de16258], but there are some changes which are common, so I have rebased to give give due credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adiSuper94 @novemberborn @jmarkham828 @macarie @erights @jonathansamines @tymfear @JSimoni42