Make AVA display subdirs properly and be recursive by default. #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| this.base += path.sep; | ||
| }; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Naturally, I spend 30 minutes on something to find out that there's already something that does that.
ariporad
force-pushed
the
recursive
branch
2 times, most recently
from
91d178c to
db85c03
Compare
|
@sindresorhus: What's the status on this? Is there anything blocking it from getting merged? |
|
@ariporad At least one other maintainer need to review it. Next time try to make your PR focused. This should probably have been two separate PRs. |
|
@sindresorhus: sorry about that, I had mentally sorted it by issue, but that doesn't make much sense outside my head. Since I implemented them sequentially, I could split them into seperate PRs, should I do that? |
|
Closing this to split into multiple pull request. |
This was referenced Dec 27, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.