Better test prefixes #379
Merged
Better test prefixes #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ariporad Could you describe what this PR improves/fixes and provide an example of before/after output? |
|
@vdemedes: on mobile atm, but I'll post a screenshot when I get back. Basically, it properly displayes subdirectories with the default reporter. |
| @@ -195,7 +192,7 @@ function handlePaths(files) { | |||
| files = [ | |||
| 'test.js', | |||
| 'test-*.js', | |||
| 'test/*.js' | |||
| 'test' | |||
There was a problem hiding this comment.
This should be in the other PR.
There was a problem hiding this comment.
@sindresorhus: Fixed.
|
@vdemedes: I uploaded some screenshots. |
ariporad
force-pushed
the
better-test-prefixes
branch
from
04283ac to
c56ed9e
Compare
|
Great, thanks! |
|
LGTM |
|
@vdemedes: Everything else look good about this PR? |
|
@sindresorhus: Sorry if this is stupid, but why isn't there a |
|
@sindresorhus: Ok, thanks. |
|
@sindresorhus: I'm going to merge this, is that OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK @sindresorhus, This is half of #373, and half of the fixes #370. I think the git history is pretty clean, but let me know if there's anything I should fix.
Before:
After:
Files: