ci(repo): Fix integration test runner #2564
Conversation
| @@ -30,6 +30,7 @@ jobs: | |||
| - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0 | |||
| with: | |||
| persist-credentials: false | |||
| submodules: true | |||
There was a problem hiding this comment.
question: Is this needed only for android or for other instances of checkout here for other platforms?
There was a problem hiding this comment.
Ah - didn't see there were separate entries. Fixed.
There was a problem hiding this comment.
Makes sense, but this instance of checkout is only for android and all the other platforms in this file use checkout so was thinking they needed same change (as they also use aft in independent runner/job in matrix).
There was a problem hiding this comment.
Missed that - thanks!
|
Does this part need additional commands for submodule, libgit setup? https://github.com/aws-amplify/amplify-flutter/blob/next/.github/composite_actions/install_dependencies/action.yaml#L20 |
Broke due to changes in aws-amplify#2068
dnys1
force-pushed
the
fix/next/integ-test-ci
branch
from
4c5d370 to
c9ef478
Compare
Ideally, no. Added a check to be safe. |
Broke due to changes in #2068.