Skip to content

ci(repo): Fix integration test runner #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023
Merged

ci(repo): Fix integration test runner #2564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/composite_actions/install_dependencies/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ runs:
# Install aft from path, links packages and runs build runner where needed.
- name: Partial aft bootstrap
run: |
git submodule update --init
flutter pub global activate -spath packages/aft
flutter pub global run aft link
flutter pub global run melos exec -c 1 --scope="amplify_secure_storage_dart,amplify_auth_cognito_dart" -- dart run build_runner build --delete-conflicting-outputs
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/amplify_integration_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is this needed only for android or for other instances of checkout here for other platforms?

Copy link
Contributor Author

@dnys1 dnys1 Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - didn't see there were separate entries. Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but this instance of checkout is only for android and all the other platforms in this file use checkout so was thinking they needed same change (as they also use aft in independent runner/job in matrix).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that - thanks!


# Flutter requires Java 11 to build android apps with Gradle.
- uses: actions/setup-java@de1bb2b0c5634f0fc4438d7aa9944e68f9bf86cc # 3.6.0
Expand Down Expand Up @@ -76,6 +77,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
Expand Down Expand Up @@ -115,6 +117,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
Expand Down Expand Up @@ -153,6 +156,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
Expand Down Expand Up @@ -189,6 +193,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
Expand Down Expand Up @@ -225,6 +230,7 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # 3.1.0
with:
persist-credentials: false
submodules: true

- name: Change path restrictions
run: git config --global core.longpaths true
Expand Down