Add SRIOV and RAM to initialisms #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
approved these changes
May 3, 2022
| @@ -67,8 +68,12 @@ func TestNames(t *testing.T) { | |||
| {"NativeAuditFieldsIncluded", "NativeAuditFieldsIncluded", "nativeAuditFieldsIncluded", "native_audit_fields_included"}, | |||
| {"NumberOfAmiToKeep", "NumberOfAMIToKeep", "numberOfAMIToKeep", "number_of_ami_to_keep"}, | |||
| {"Package", "Package", "package_", "package_"}, | |||
| {"Param", "Param", "param", "param"}, | |||
| @@ -119,10 +119,13 @@ var ( | |||
| {"Nat", "NAT", "nat", regexp.MustCompile("Nat(?!i)", regexp.None)}, | |||
| {"Oidc", "OIDC", "oidc", nil}, | |||
| {"Ocsp", "OCSP", "ocsp", nil}, | |||
| // Model fields starting with 'Ram' refer to RAM | |||
| {"Ram", "RAM", "ram", regexp.MustCompile("Ram", regexp.None)}, | |||
There was a problem hiding this comment.
I think this will be OK... I'm not sure if there are fields like pctRam or percentRam or something like that which we would need to keep an eye out for though.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brycahta, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
brycahta
commented
May 3, 2022
| @@ -119,10 +119,13 @@ var ( | |||
| {"Nat", "NAT", "nat", regexp.MustCompile("Nat(?!i)", regexp.None)}, | |||
| {"Oidc", "OIDC", "oidc", nil}, | |||
| {"Ocsp", "OCSP", "ocsp", nil}, | |||
| // Model fields starting with 'Ram' refer to RAM | |||
| {"Ram", "RAM", "ram", regexp.MustCompile("Ram", regexp.None)}, | |||
There was a problem hiding this comment.
The rule for RAM is not exhaustive, ex: rambunctious, ramification, Ramadan. However, I deep dived the models to validate this simpler rule should work for all controllers.
In aws-sdk-go/models/apis , executed grep -r '[a-zA-Z]*ram[a-zA-Z]*' -o . | sort | uniq:
addThingsToThingGroupParams
algorithmHyperParameters
cacheKeyParameters
categoricalHyperParameterRanges
containerParams
continuousHyperParameterRanges
datagram
datagrams
diagram
dropframe
emitProgram
enableIoTLoggingParams
exactFramerate
frame
frameMetric
frameMetricData
frameMetrics
frameName
framerate
framerateControl
framerateDenominator
framerateNumerator
framerates
frames
framework
frameworkId
frameworkMetadataList
frameworkName
frameworkType
frameworks
gopNumBFrames
grammar
histogram
hyperparameter
hyperparameters
iframe
integerHyperParameterRanges
keyframe
linuxProcessParams
logParameters
maxFrameAverageLightLevel
mydbclusterparametergroup
mydbparametergroup
mydbparamgroup
mymysqlparametergroup
numberBFrames
numberBFramesBetweenReferenceFrames
param
parameter
parameterName
parameterValue
parameterized
parameters
paramount
params
paramstore
program
programDateTimeIntervalSeconds
programName
programNumber
programlisting
programmatic
programmatically
programmer
programming
programs
publishFindingToSnsParams
ram
ramdisk
replaceDefaultPolicyVersionParams
requestParameterKey
requestParameters
responseParameters
scram
signingProfileParameter
timeframe
updateCACertificateParams
updateDeviceCertificateParams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-controllers-k8s/ec2-controller#52
Description of changes:
SRIOVandRAMto initialisms with updated testsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.