Skip to content

Generate Reservation CRD #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Generate Reservation CRD #52

wants to merge 6 commits into from

Conversation

brycahta
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1196

Description of changes:

  • Allows the creation and termination of multiple instances by defining a Reservation resource backed by RunInstances , DescribeInstances, and TerminateInstances apis

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from bwagner5 and vijtrip2 April 27, 2022 21:22
@brycahta brycahta requested a review from pdk27 April 27, 2022 21:22
@brycahta
Copy link
Contributor Author

kubectl describe reservations sample output: https://gist.github.com/brycahta/66b1bea8c6f8810996344cc0bc0f0fee

This was a reservation for 2 instances and note the Status section contains all instance details so kinda beefy.

@vijtrip2
Copy link

/approve

a-hilaly
a-hilaly approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👌

@ack-bot
Copy link
Collaborator

ack-bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,brycahta,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RedbackThomson
RedbackThomson suggested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great. I love that you went with Reservation as the CRD name - although SEO might be a bit tough for documentation, so hopefully we can figure that out. I have some initialisms for you, and some field paths to ignore, but nothing crazy.

apis/v1alpha1/types.go
// response element if the instance explicily targets a specific Capacity Reservation
// or Capacity Reservation group.
CapacityReservationSpecification *CapacityReservationSpecificationResponse `json:"capacityReservationSpecification,omitempty"`
ClientToken *string `json:"clientToken,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to ignored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from the Describe call, I believe. Please check

@brycahta brycahta mentioned this pull request May 3, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this pull request May 3, 2022
@brycahta
Add SRIOV and RAM to initialisms (#330)
95f81d3 
Issue #, if available: aws-controllers-k8s/ec2-controller#52

Description of changes:
* adds `SRIOV` and `RAM` to initialisms with updated tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@brycahta brycahta mentioned this pull request May 3, 2022
Merged
ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this pull request May 3, 2022
@brycahta
update RAM initialism (#331)
e502fdf 
Issue #, if available: aws-controllers-k8s/ec2-controller#52

Description of changes:
* adds `Ramdisk` to initialisms because the source did not consistently camel case

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@brycahta
Copy link
Contributor Author

brycahta commented May 3, 2022

Discussed offline; renaming the resource to Instance and hard-coding min/max count to 1, so a single instance is created and can be managed/modified by the controller (i.e. able add volume to instance). If we proceed with Reservation, then there is no way to update the reservation/collection of instances in this way.

@brycahta
Copy link
Contributor Author

Stale; re-genning as Instance once aws-controllers-k8s/community#1285 is resolved

@brycahta brycahta closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedbackThomson RedbackThomson RedbackThomson requested changes

@a-hilaly a-hilaly a-hilaly approved these changes

@vijtrip2 vijtrip2 vijtrip2 approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5

@pdk27 pdk27 Awaiting requested review from pdk27

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brycahta @vijtrip2 @ack-bot @RedbackThomson @a-hilaly