Skip to content

feat: report feature flags into Cloud Assembly #34884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 2, 2025

This is a re-roll of #34798 which had to be reverted.

It includes a new version of the Cloud Assembly Schema to make sure users don't get the "failed to validate Assembly Manifest" error, but instead get the "you need to update your CLI" error.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is a re-roll of #34798, including a new version of the Cloud
Assembly Schema to make sure users get the right error message.
@rix0rrr rix0rrr requested a review from a team as a code owner July 2, 2025 11:36
@aws-cdk-automation aws-cdk-automation requested a review from a team July 2, 2025 11:36
@github-actions github-actions bot added the p2 label Jul 2, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 2, 2025 12:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 2, 2025
Copy link
Contributor

mergify bot commented Jul 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6d378b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f70e46c into main Jul 2, 2025
18 checks passed
@mergify mergify bot deleted the huijbers/reapply-feature-flag-report branch July 2, 2025 18:03
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants