chore(verfication): remove {:only} #517
Conversation
|
It looks like you are adding or removing the dafny keyword {:only}. |
|
It looks like you are adding or removing the dafny keyword {:only}. |
| - name: Check if ONLY_KEYWORD is not empty | ||
| id: comment | ||
| env: | ||
| PR_NUMBER: ${{ github.event.number }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| ONLY_KEYWORD: ${{ steps.only-keyword.outputs.ONLY_KEYWORD }} | ||
| if: ${{env.ONLY_KEYWORD != ''}} | ||
| run: | | ||
| COMMENT="It looks like you are adding or removing the dafny keyword {:only}.\nIs this intended?" |
There was a problem hiding this comment.
Why not just have this action fail? If I'm working on a PR and it does not pass for this reason, that feels like a good thing?
|
It looks like you are adding or removing the dafny keyword {:only}. |
|
Although the action, |
* chore: Remove Dafny warnings
Remove all Dafny warnings and set warnings to error.
By removing all the errors, --allow-warnings can be removed from verification. This means that any verification warning will now fail the build. This is especially relevant if {:only} is ever committed. See #517. This would now cause CI verification to fail.
Remove all Dafny warnings and set warnings to error.
By removing all the errors,
--allow-warnings can be removed from verification.
This means that any verification warning will now fail the build.
This is especially relevant if {:only} is ever committed.
See aws/aws-cryptographic-material-providers-library#517.
This would now cause CI verification to fail.
Remove all Dafny warnings and set warnings to error.
By removing all the errors,
--allow-warnings can be removed from verification.
This means that any verification warning will now fail the build.
This is especially relevant if {:only} is ever committed.
See aws/aws-cryptographic-material-providers-library#517.
This would now cause CI verification to fail.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.