-
Notifications
You must be signed in to change notification settings - Fork 16
chore(verfication): remove {:only} #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3bd8bbf
chore(verfication): remove {:only}
josecorella d474f36
add needs
josecorella 42ebbc6
remove unused class member
josecorella e2fc7d5
add check only keyword gha
josecorella 321788e
update
josecorella 09efcbe
a
josecorella d42f7ab
remove name-only
josecorella 6e182a7
remove quotes
josecorella 5d823f3
)
josecorella 5752d2c
format
josecorella e818de7
fail step if triggered
josecorella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# This workflow checks if you are checking in dafny code | ||
# with the keyword {:only}, it adds a message to the pull | ||
# request to remind you to remove it. | ||
name: Check {:only} decorator presence | ||
|
||
on: | ||
pull_request: | ||
|
||
jobs: | ||
grep-only-verification-keyword: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
issues: write | ||
pull-requests: write | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Check only keyword | ||
id: only-keyword | ||
shell: bash | ||
run: | ||
# checking in code with the dafny decorator {:only} | ||
# will not verify the entire file or maybe the entire project depending on its configuration | ||
# This action checks if you are either adding or removing the {:only} decorator and posting on the pr if you are. | ||
echo "ONLY_KEYWORD=$(git diff origin/main origin/${GITHUB_HEAD_REF} **/*.dfy | grep -i {:only})" >> "$GITHUB_OUTPUT" | ||
|
||
- name: Check if ONLY_KEYWORD is not empty | ||
id: comment | ||
env: | ||
PR_NUMBER: ${{ github.event.number }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
ONLY_KEYWORD: ${{ steps.only-keyword.outputs.ONLY_KEYWORD }} | ||
if: ${{env.ONLY_KEYWORD != ''}} | ||
run: | | ||
COMMENT="It looks like you are adding or removing the dafny keyword {:only}.\nIs this intended?" | ||
COMMENT_URL="https://api.github.com/repos/${{ github.repository }}/issues/${PR_NUMBER}/comments" | ||
curl -s -H "Authorization: token ${GITHUB_TOKEN}" -X POST $COMMENT_URL -d "{\"body\":\"$COMMENT\"}" | ||
exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just have this action fail? If I'm working on a PR and it does not pass for this reason, that feels like a good thing?