Allow SDK to be be browserified without custom scripts #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works without any custom code. Note that by default only the
default services will be included in the browserified aws-sdk
build. In order to build other services, you can pass the
`AWS_SERVICES` environment variable to browserify:
AWS_SERVICES=s3,ec2,dynamodb browserify myscript.js > out.js
The above command includes only Amazon S3, Amazon EC2, and Amazon
DynamoDB in the generated SDK. You can use "all" to include all
services.
See #383
Caching logic was incompatible with new build format, as caching worked by generating service cache data outside of core module. Services are now built inside of the context of the core module. dist-tools was refactored to use the new transform function to drive building of service code.
AdityaManohar
added a commit
that referenced
this pull request
Oct 16, 2014
Allow SDK to be be browserified without custom scripts Closes #383
lsegal
added a commit
that referenced
this pull request
Oct 16, 2014
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the SDK to work with
browserifyout of the box. Consider the following application code that uses the SDK:Currently, this file would not work with:
$ browserify index.js > out.jsThis patch allows the above command to succeed with the default SDK browser build. This patch also allows for custom services to be specified when browserifying via
AWS_SERVICES:$ AWS_SERVICES=ec2 browserify index.js > out.jsThis relates to #383