Fix security scanning for fork-origin PRs #55
Merged
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR addresses an issue for the security scanning workflow when new PRs are created from forks. The security scan workflow must check out out code from the PR branch and then run scans on it. However, for a fork-origin PR, the PR branch does not exist in the
aws/code-editor
repo, it only exists in the fork repo.The scan workflow used to error out before as it was unable to find the PR branch. The current PR fixes that by relying on
github.event.pull_request.head.sha
when the workflow is invoked for apull_request_target
event.Besides that, this PR also removes the prefix
security-
fromrole-session-name
when assuming the AWS IAM role. This is because therole-session-name
has a 64 character limit and a few PRs have failed on this step because the character limit was breached.Testing
Tested out for fork-origin PR and for branch-origin PR in a fork:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.