Skip to content

Fix security scanning for fork-origin PRs #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
+8 −4
Merged

Fix security scanning for fork-origin PRs #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/security-scan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:
with:
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
aws-region: us-east-1
role-session-name: security-scan-${{ matrix.target }}-${{matrix.branch}}
role-session-name: scan-${{ matrix.target }}-${{matrix.branch}}

- name: Publish Scan Invoked metric
run: |
Expand All @@ -248,7 +248,9 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
# For fork-origin PRs, we can't directly use matrix.branch as the branch does not exist in the
# Code Editor repo. The branch only exists in the fork.
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || matrix.branch }}
submodules: recursive

- name: Update security scan script from main
Expand Down Expand Up @@ -440,7 +442,7 @@ jobs:
with:
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
aws-region: us-east-1
role-session-name: security-scan-global-dependencies-${{matrix.branch}}
role-session-name: scan-global-dependencies-${{matrix.branch}}

- name: Publish Scan Invoked metric
run: |
Expand All @@ -453,7 +455,9 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
# For fork-origin PRs, we can't directly use matrix.branch as the branch does not exist in the
# Code Editor repo. The branch only exists in the fork.
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || matrix.branch }}
submodules: recursive

- name: Update security scan script from main
Expand Down