Box ControlPair to reduce copy overhead #2753
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ControlPair is 2.5kb large (2 copies of the full HMAC state). That's maybe possible to shrink directly, but since we pass ControlPair around by value it's good to add some indirection to avoid copying the large value. The ControlPair is also not created at all in the TCP stream case, so this is a pure win there. Not measured independently (currently that's a bit slow to do) but doesn't appear that this makes any meaningful end-to-end performance difference. Seems like a clear win for the TCP case though.
|
Actually, changes need to be deeper to be effective, we move out of the struct changed here pretty quickly. Will update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
ControlPair is 2.5kb large (2 copies of the full HMAC state). That's maybe possible to shrink directly, but since we pass ControlPair around by value it's good to add some indirection to avoid copying the large value. The ControlPair is also not created at all in the TCP stream case, so this is a pure win there.
Not measured independently (currently that's a bit slow to do) but doesn't appear that this makes any meaningful end-to-end performance difference. Seems like a clear win for the TCP case though.
Call-outs:
n/a
Testing:
Existing tests cover the changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.