Skip to content

Box ControlPair to reduce copy overhead #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Box ControlPair to reduce copy overhead #2753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dc/s2n-quic-dc/src/path/secret/map/entry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ impl Entry {
let control = if features.is_reliable() {
None
} else {
Some(ControlPair::new(&self.secret, key_id, initiator))
Some(Box::new(ControlPair::new(&self.secret, key_id, initiator)))
};

Bidirectional {
Expand Down Expand Up @@ -253,7 +253,7 @@ impl Entry {
let control = if features.is_reliable() {
None
} else {
Some(ControlPair::new(&self.secret, key_id, initiator))
Some(Box::new(ControlPair::new(&self.secret, key_id, initiator)))
};

Bidirectional {
Expand Down Expand Up @@ -331,7 +331,7 @@ impl receiver::Error {
pub struct Bidirectional {
pub credentials: Credentials,
pub application: ApplicationPair,
pub control: Option<ControlPair>,
pub control: Option<Box<ControlPair>>,
}

pub struct ApplicationPair {
Expand Down
Loading