chore(bindings): revert dependency pins #5544
Open
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouho
reviewed
Oct 3, 2025
| regex = "=1.9.6" # newer versions require rust 1.65, see https://github.com/aws/s2n-tls/issues/4242 | ||
| home = "=0.5.5" # newer versions require rust 1.70, see https://github.com/aws/s2n-tls/issues/4395 | ||
| libloading = "=0.8.8" # newer versions require rust 1.71, see https://github.com/aws/s2n-tls/issues/4395 | ||
| # newer versions require 1.81 |
There was a problem hiding this comment.
Can we create a tracking issue for this?
There was a problem hiding this comment.
I don't mind it, but I also don't think it's actually effective.
When we bumped the version we didn't actually use that tracking issue to fix any of the things 🤷
There was a problem hiding this comment.
Yeah I don't have a strong preference, but at least I thought it was nice to be able to see all the (documented) pinned dependencies with a search on github issues
jouho
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #5536
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.