Skip to content

chore(bindings): revert dependency pins #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −7
Open

chore(bindings): revert dependency pins #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00a8643
chore(bindings): revert dependency pins
jmayclin Oct 3, 2025
8dfeb08
repin home
jmayclin Oct 3, 2025
32d5007
update generated cargo toml
jmayclin Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bindings/rust/extended/generate/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ publish = false
[dependencies]
bindgen = "0.65"
glob = "0.3"
regex = "=1.9.6" # newer versions require rust 1.65, see https://github.com/aws/s2n-tls/issues/4242
home = "=0.5.5" # newer versions require rust 1.70, see https://github.com/aws/s2n-tls/issues/4395
libloading = "=0.8.8" # newer versions require rust 1.71, see https://github.com/aws/s2n-tls/issues/4395
# newer versions require 1.81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a tracking issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it, but I also don't think it's actually effective.

When we bumped the version we didn't actually use that tracking issue to fix any of the things 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't have a strong preference, but at least I thought it was nice to be able to see all the (documented) pinned dependencies with a search on github issues

home = "=0.5.9"
3 changes: 0 additions & 3 deletions bindings/rust/extended/s2n-tls-tokio/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,3 @@ tokio = { version = "1", features = ["net", "time"] }
s2n-tls = { path = "../s2n-tls", features = ["unstable-testing"] }
rand = { version = "0.9" }
tokio = { version = "1", features = [ "io-std", "io-util", "macros", "net", "rt-multi-thread", "test-util", "time"] }
tokio-macros = "=2.3.0" # newer versions require rust 1.70, see https://github.com/aws/s2n-tls/issues/4395
parking_lot_core = "=0.9.10" # newer versions require rust 1.64, see https://github.com/aws/s2n-tls/issues/5339
lock_api = "=0.4.12" # newer versions require rust 1.64, see https://github.com/aws/s2n-tls/issues/5339
1 change: 0 additions & 1 deletion bindings/rust/extended/s2n-tls/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ hex = "0.4"

[dev-dependencies]
futures-test = "0.3"
once_cell = "=1.20.3" # newer versions require rust 1.70.0
openssl = "0.10"
openssl-sys = "0.9"
foreign-types = "0.3" # newer versions require updated ForeignTypeRef, see https://github.com/sfackler/rust-openssl/issues/2298
Expand Down
Loading