Skip to content

added unit tests for athena-oracle. #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christov merged 4 commits into from
Oct 31, 2025
Merged

added unit tests for athena-oracle. #2836

christov merged 4 commits into from
Oct 31, 2025

Conversation

@ritiktrianz
Copy link
Contributor

@ritiktrianz ritiktrianz commented Jun 20, 2025

Issue #, if available:

Description of changes:
Added unit tests for athena-oracle connector.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.25%. Comparing base (fe0a5d9) to head (4239394).
⚠️ Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
...connectors/oracle/OracleJdbcConnectionFactory.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2836      +/-   ##
============================================
+ Coverage     63.67%   67.25%   +3.58%     
- Complexity     4344     4887     +543     
============================================
  Files           621      635      +14     
  Lines         23286    24135     +849     
  Branches       2859     2996     +137     
============================================
+ Hits          14827    16232    +1405     
+ Misses         7070     6460     -610     
- Partials       1389     1443      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ritiktrianz ritiktrianz force-pushed the oracle-unit-tests branch 3 times, most recently from 5a06ea6 to b7a3775 Compare August 21, 2025 10:14
aimethed
aimethed previously approved these changes Aug 27, 2025
View reviewed changes
aimethed
aimethed reviewed Aug 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java Outdated
public void testGetConnection_withSsl() throws Exception {
Driver mockDriver = mock(Driver.class);

withEnvironmentVariable("is_fips_enabled", "true").execute(() -> {
Copy link
Contributor

@aimethed aimethed Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked in the code and this is the correct check. But what is the behavior for connectors using glue connections? Do customers need to set the lambda environment variable as well?

Copy link
Contributor Author

@ritiktrianz ritiktrianz Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aimethed ,
Thank you for reviewing. Yes, If customers want to use FIPS mode, they should set the Lambda environment variable "is_fips_enabled" to true. Please find the official documentation link below for your reference.
https://docs.aws.amazon.com/athena/latest/ug/connectors-oracle.html#connectors-oracle-parameters.

aimethed
aimethed previously approved these changes Oct 7, 2025
View reviewed changes
christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java Outdated
Driver drv = DriverManager.getDriver(originalURL);
String driverClass = drv.getClass().getName();
Assert.assertEquals("oracle.jdbc.OracleDriver", driverClass);
assertEquals("oracle.jdbc.OracleDriver", driverClass);
Copy link
Contributor

@christov christov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am reading this test correctly, it is expected to throw an exception. If that is the case, why is there an assert statement?

Also, which statement is expected to throw the exception and why?

A couple of suggestions if my understanding of this test is correct:

  • Remove the assert statement and any irrelevant code and keep only the code necessary to trigger the exception.
  • Update the test name to reflect the situation that this test targets. For example, testGetConnection_throwsAnExceptionWhen...

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @christov thank you for reviewing.
This was an existing test, which was incorrect. A similar (and correct) test case has already been added:
getConnection_whenDriverClassNotFound_throwsRuntimeException().
Hence, this test has been removed.

christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java Outdated
}

@Test
public void testGetConnection_withSsl() throws Exception {
Copy link
Contributor

@christov christov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, specify what this test tests in the test method name (see previous comment for naming convention suggestion. Also, the existing test on line 154 follows a similar convention).

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test method has been renamed accordingly.

christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java Outdated
sslProps.getProperty("oracle.net.ssl_cipher_suites")
);

DriverManager.deregisterDriver(mockDriver);
Copy link
Contributor

@christov christov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clean-up code will not be executed if one of the assertions fails. It will be safer if a try/finally statement is used.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement has been moved into a finally block.

christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java

DriverManager.registerDriver(mockDriver);

new OracleJdbcConnectionFactory(config, info).getConnection(credentialsProvider);
Copy link
Contributor

@christov christov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation of this and the next line.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java
DriverManager.registerDriver(mockDriver);

new OracleJdbcConnectionFactory(config, info).getConnection(credentialsProvider);
DriverManager.deregisterDriver(mockDriver);
Copy link
Contributor

@christov christov Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line will run given that an exception is expected to be thrown earlier. See a previous comment about using try/finally.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement has been moved into a finally block.

christov
christov reviewed Oct 27, 2025
View reviewed changes
...le/src/test/java/com/amazonaws/athena/connectors/oracle/OracleJdbcConnectionFactoryTest.java Outdated
}

@Test(expected = RuntimeException.class)
public void getConnection_whenDriverClassNotFound_throwsRuntimeException()
Copy link
Contributor

@christov christov Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming: this method should also start with test like the rest of the methods in this class. Alternatively, each test method can start with the name of the method under test, but we need to be consistent.

I am leaning toward the latter--skip test since the method is already annotated with @Test and it is inside of a class that has Test in its name.

Let's do the following for all Oracle unit tests:

  • For each class with production code, have one test class that has the same name but it ends with Test
  • For each method we're testing (usually these are the methods externally visible from a class), have one or more test methods that follow the naming convention <methodUnderTest>_<doesXyzWhenAbc>.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other test methods have been renamed to align with this naming convention.

christov
christov requested changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@christov christov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address the comments in this review.

For this comment, please apply its test naming suggestions across all Oracle unit tests.

@Jithendar12
Copy link
Contributor

Jithendar12 commented Oct 28, 2025

Please, address the comments in this review.

For this comment, please apply its test naming suggestions across all Oracle unit tests.

All test methods across the Oracle connector have been renamed to follow the convention:
MethodName_StateUnderTest_ExpectedBehavior

christov
christov reviewed Oct 30, 2025
View reviewed changes
...rc/test/java/com/amazonaws/athena/connectors/oracle/resolver/OracleJDBCCaseResolverTest.java Outdated
}

@Test
public void getAdjustedSchemaNameString_whenCaseInsensitiveMode_schemaNameCasingAdjusted() throws SQLException
Copy link
Contributor

@christov christov Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The test name will be more informative if it said how the schema name was adjusted. E.g., "schema name is lower cased" or something along those lines. This applies to other tests in this class too.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated test names to clarify how the schema/table name is adjusted.

christov
christov reviewed Oct 31, 2025
View reviewed changes
...a-oracle/src/test/java/com/amazonaws/athena/connectors/oracle/OracleMetadataHandlerTest.java Outdated

@Test
public void getPartitionSchema()
public void getPartitionSchema_whenCalled_returnsPartitionSchema()
Copy link
Contributor

@christov christov Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: "whenCalled" is not necessary--it is clear that the method will need to be called to return something. In this situation, it's fine to just skip the "when" part from the method name--that's the vanilla case/happy path. It is useful to add "when ..." when there is a specific condition/situation that is being tested (which is usually all other cases except for the "vanilla case").

"whenCalled" can be removed from other test methods too.

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unnecessary "whenCalled" from test names.

christov
christov reviewed Oct 31, 2025
View reviewed changes
...a-oracle/src/test/java/com/amazonaws/athena/connectors/oracle/OracleMetadataHandlerTest.java Outdated
}

@Test
public void doGetTable_whenUnsupportedColumnTypes_fallbackToVarchar() throws Exception
Copy link
Contributor

@christov christov Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: "fallsBackToVarchar" (i.e., use a verb since this is about what the method does, and to be consistent with the naming of the other tests).

Copy link
Contributor

@Jithendar12 Jithendar12 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed with fallsBackToVarchar.

christov
christov requested changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@christov christov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the previous comments. The test names are much clearer now! I had just a few minor nitpicks on the latest version.

@Jithendar12
Copy link
Contributor

Jithendar12 commented Oct 31, 2025

Thank you for addressing the previous comments. The test names are much clearer now! I had just a few minor nitpicks on the latest version.

Hi @christov , thanks for the suggestions! I’ve addressed these minor nitpicks as well.

@christov christov merged commit c1e594f into awslabs:master Oct 31, 2025
7 of 8 checks passed
Jithendar12 pushed a commit to Jithendar12/aws-athena-query-federation that referenced this pull request Nov 5, 2025
@ritiktrianz @Jithendar12
Add unit tests for athena-oracle. (awslabs#2836)
4c600d4 
Authored-by: Jithendar12 <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
Cut release 2025.46.1
6a0779d 
  - Added unit tests in athena-synapse Connector (#2963)
  - Updating EncryptionKeyFactory to add overirde AWS request configuration in KMS calls made generate encryption key (#3103)
  - Fix epoch date conversion correctness issue when machine time zone is not in UTC (#3108)
  - Fix CVE-2025-48924: Upgrade Apache Commons Lang3 to 3.19.0 (#3100)
  - Revise Athena Federated Queries instructions in README (#3069)
  - fix snowflake QPT return empty result (#3106)
  - add view into oracle paginated query (#3107)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.32.1 to 4.33.0 (#3071)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.7 to 4.9.8 (#3076)
  - build(deps): bump org.apache.avro:avro from 1.12.0 to 1.12.1 (#3075)
  - Handle ResourceNotFoundException from Dynamodb as AthenaConnectorExce… (#3098)
  - Added unit tests for bigquery (#2950)
  - Update PostgreSQL engine version to 15.10 (#3099)
  - Add unit tests for athena-oracle. (#2836)
  - Adding support to use custom SecretManagerClient for Google Big Query (#2846)
github-actions bot pushed a commit to Jithendar12/aws-athena-query-federation that referenced this pull request Nov 28, 2025
Cut release 2025.47.1
80d8cef 
  - Update runner and slug
  - Update GitHub Actions workflows to build with Java 11 and 17
  - Remove hard-coded Glue list-jobs --max-results 100 to find all Glue jobs (awslabs#3127)
  - Added unit tests in athena-synapse Connector (awslabs#2963)
  - Updating EncryptionKeyFactory to add overirde AWS request configuration in KMS calls made generate encryption key (awslabs#3103)
  - Fix epoch date conversion correctness issue when machine time zone is not in UTC (awslabs#3108)
  - Fix CVE-2025-48924: Upgrade Apache Commons Lang3 to 3.19.0 (awslabs#3100)
  - Revise Athena Federated Queries instructions in README (awslabs#3069)
  - fix snowflake QPT return empty result (awslabs#3106)
  - add view into oracle paginated query (awslabs#3107)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.32.1 to 4.33.0 (awslabs#3071)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.7 to 4.9.8 (awslabs#3076)
  - build(deps): bump org.apache.avro:avro from 1.12.0 to 1.12.1 (awslabs#3075)
  - Handle ResourceNotFoundException from Dynamodb as AthenaConnectorExce… (awslabs#3098)
  - Added unit tests for bigquery (awslabs#2950)
  - Update PostgreSQL engine version to 15.10 (awslabs#3099)
  - Add unit tests for athena-oracle. (awslabs#2836)
  - Adding support to use custom SecretManagerClient for Google Big Query (awslabs#2846)
  - Added unit tests for athena-cloudera-impala Connector (awslabs#2880)
  - added unit tests for athena-vertica. (awslabs#2783)
  - added unit tests for athena-redshift. (awslabs#2733)
  - Always include partition column when get-table-layout (awslabs#3045)
  - fix cloudwatch glue connection cfn template (awslabs#3013)
  - Added unit tests for JDBC module (awslabs#2732)
  - Added pagination for Db2 connector (awslabs#2772)
  - [Fix] Include default truststore path when passing JAVA_TOOL_OPTIONS for Java 17 image (awslabs#3007)
  - build(deps): bump com.google.guava:guava from 33.4.0-jre to 33.4.8-jre (awslabs#2728)
  - Handle KMS and DDB NotFoundExceptions by throwing AthenaConnectorException (awslabs#3064)
  - build(deps): bump aws-sdk-v2.version from 2.35.1 to 2.35.5 (awslabs#3047)
  - build(deps): bump io.confluent:kafka-avro-serializer from 8.0.0 to 8.0.2 (awslabs#3055)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.35.0 to 2.35.5 (awslabs#3057)
  - build(deps): bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.1 to 3.9.0 (awslabs#3061)
  - Remove timestamp case from SnowflakeQueryStringBuilder (awslabs#2997)
  - build(deps): bump io.substrait.version from 0.65.0 to 0.66.0 (awslabs#3051)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.58.0 to 2.58.1 (awslabs#3059)
  - build(deps): bump org.postgresql:postgresql from 42.7.7 to 42.7.8 (awslabs#3063)
  - build(deps): bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.3 to 3.12.0 (awslabs#3062)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.4 to 4.9.6 (awslabs#3058)
  - build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.13 to 0.8.14 (awslabs#3060)
  - build(deps): bump net.sf.jt400:jt400 from 21.0.5 to 21.0.6 (awslabs#3053)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.50 to 20.00.00.51 (awslabs#3054)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.3 to 9.1.5 (awslabs#3056)
  - build(deps): bump org.bouncycastle:bcpkix-jdk18on from 1.81 to 1.82 (awslabs#3050)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.6 to 5.2.0 (awslabs#3052)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.114.1 to 1.115.0 (awslabs#3048)
  - build(deps): bump aws-sdk-v2.version from 2.34.5 to 2.35.0 (awslabs#3039)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.1.1 to 4.2 (awslabs#3037)
  - build(deps): bump aws-sdk.version from 1.12.791 to 1.12.792 (awslabs#3035)
  - build(deps): bump net.java.dev.jna:jna-platform from 5.17.0 to 5.18.1 (awslabs#3038)
  - build(deps-dev): bump log4j2Version from 2.25.1 to 2.25.2 (awslabs#3029)
  - build(deps): bump io.substrait.version from 0.52.0 to 0.65.0 (awslabs#3021)
  - build(deps): bump org.assertj:assertj-core from 3.27.4 to 3.27.6 (awslabs#3019)
  - build(deps): bump com.amazonaws:aws-lambda-java-core from 1.3.0 to 1.4.0 (awslabs#3020)
  - build(deps): bump net.java.dev.jna:jna from 5.17.0 to 5.18.1 (awslabs#3034)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib from 2.2.10 to 2.2.20 (awslabs#3027)
  - build(deps): bump org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0 (awslabs#3033)
  - build(deps): bump org.bouncycastle:bcprov-jdk18on from 1.81 to 1.82 (awslabs#3022)
  - build(deps): bump org.bouncycastle:bcutil-jdk18on from 1.81 to 1.82 (awslabs#3024)
  - build(deps): bump org.sonatype.central:central-publishing-maven-plugin from 0.8.0 to 0.9.0 (awslabs#3026)
  - build(deps): bump org.codehaus.mojo:license-maven-plugin from 2.6.0 to 2.7.0 (awslabs#3023)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.33.8 to 2.35.0 (awslabs#3040)
  - Add Support for OAuth in athena-saphana Connector (awslabs#2894)
  - build(deps): bump aws-actions/configure-aws-credentials from 4 to 5 (awslabs#2975)
  - build(deps): bump actions/setup-node from 4 to 5 (awslabs#2976)
  - [Neptune] Add doc details on how multi-valued properties are handled. (awslabs#2995)
  - build(deps): bump org.jetbrains.kotlin:kotlin-reflect from 2.2.10 to 2.2.20 (awslabs#3028)
  - build(deps): bump software.amazon.glue:schema-registry-serde from 1.1.24 to 1.1.25 (awslabs#3030)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.2.10 to 2.2.20 (awslabs#3031)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.49 to 20.00.00.50 (awslabs#3032)
  - build(deps): bump aws-sdk-v2.version from 2.34.3 to 2.34.5 (awslabs#3017)
  - Add Support for OAuth in athena-sqlserver Connector (awslabs#3006)
  - Add Support for OAuth in athena-synapse Connector (awslabs#2904)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.113.0 to 1.114.1 (awslabs#2979)
  - build(deps): bump org.apache.calcite.version from 1.39.0 to 1.40.0 (awslabs#2980)
  - build(deps): bump aws-sdk.version from 1.12.788 to 1.12.791 (awslabs#2981)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.4 to 5.1.5 (awslabs#2983)
  - build(deps): bump com.clickhouse:clickhouse-jdbc from 0.9.1 to 0.9.2 (awslabs#2985)
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.26.0 to 3.26.1 (awslabs#2987)
  - build(deps): bump org.yaml:snakeyaml from 2.4 to 2.5 (awslabs#2988)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.0.9 to 4.1 (awslabs#2998)
  - build(deps): bump aws-sdk-v2.version from 2.32.29 to 2.33.9 (awslabs#2999)
  - build(deps): bump org.apache.kafka:kafka-clients from 4.0.0 to 4.1.0 (awslabs#3000)
  - build(deps): bump surefire.failsafe.version from 3.5.3 to 3.5.4 (awslabs#3001)
  - build(deps): bump com.microsoft.azure:msal4j from 1.22.0 to 1.23.1 (awslabs#3002)
  - build(deps): bump org.apache.maven.plugins:maven-shade-plugin from 3.6.0 to 3.6.1 (awslabs#3003)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.55.0 to 2.57.0 (awslabs#3004)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.25.12 to 2.26.6 (awslabs#3012)
  - build(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.0 to 3.14.1 (awslabs#3011)
  - Fixing error messages to not leak sensitive info (awslabs#3008)
  - Include linked accounts option when querying metric_samples table. (awslabs#2922)
  - Updating Zookeeper to latest version 3.9.4 (awslabs#3005)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.29.3 to 4.32.0 (awslabs#2991)
  - Add serverless datalakegen2 support (awslabs#2973)
  - Abstract common OAuth handling and add OAuth support to Athena DataLake Gen2 Connector (awslabs#2932)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.32.29 to 2.33.4 (awslabs#2992)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.2 to 9.1.3 (awslabs#2993)
  - build(deps): bump io.lettuce:lettuce-core from 6.8.0.RELEASE to 6.8.1.RELEASE (awslabs#2994)
  - Hbase namespace issue (awslabs#2996)
github-actions bot pushed a commit to Jithendar12/aws-athena-query-federation that referenced this pull request Nov 29, 2025
Cut release 2025.47.1
d0e0ad6 
  - wait for release branch and checkout
  - wait for release branch and checkout
  - Update runner and slug
  - Update GitHub Actions workflows to build with Java 11 and 17
  - Remove hard-coded Glue list-jobs --max-results 100 to find all Glue jobs (awslabs#3127)
  - Added unit tests in athena-synapse Connector (awslabs#2963)
  - Updating EncryptionKeyFactory to add overirde AWS request configuration in KMS calls made generate encryption key (awslabs#3103)
  - Fix epoch date conversion correctness issue when machine time zone is not in UTC (awslabs#3108)
  - Fix CVE-2025-48924: Upgrade Apache Commons Lang3 to 3.19.0 (awslabs#3100)
  - Revise Athena Federated Queries instructions in README (awslabs#3069)
  - fix snowflake QPT return empty result (awslabs#3106)
  - add view into oracle paginated query (awslabs#3107)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.32.1 to 4.33.0 (awslabs#3071)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.7 to 4.9.8 (awslabs#3076)
  - build(deps): bump org.apache.avro:avro from 1.12.0 to 1.12.1 (awslabs#3075)
  - Handle ResourceNotFoundException from Dynamodb as AthenaConnectorExce… (awslabs#3098)
  - Added unit tests for bigquery (awslabs#2950)
  - Update PostgreSQL engine version to 15.10 (awslabs#3099)
  - Add unit tests for athena-oracle. (awslabs#2836)
  - Adding support to use custom SecretManagerClient for Google Big Query (awslabs#2846)
  - Added unit tests for athena-cloudera-impala Connector (awslabs#2880)
  - added unit tests for athena-vertica. (awslabs#2783)
  - added unit tests for athena-redshift. (awslabs#2733)
  - Always include partition column when get-table-layout (awslabs#3045)
  - fix cloudwatch glue connection cfn template (awslabs#3013)
  - Added unit tests for JDBC module (awslabs#2732)
  - Added pagination for Db2 connector (awslabs#2772)
  - [Fix] Include default truststore path when passing JAVA_TOOL_OPTIONS for Java 17 image (awslabs#3007)
  - build(deps): bump com.google.guava:guava from 33.4.0-jre to 33.4.8-jre (awslabs#2728)
  - Handle KMS and DDB NotFoundExceptions by throwing AthenaConnectorException (awslabs#3064)
  - build(deps): bump aws-sdk-v2.version from 2.35.1 to 2.35.5 (awslabs#3047)
  - build(deps): bump io.confluent:kafka-avro-serializer from 8.0.0 to 8.0.2 (awslabs#3055)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.35.0 to 2.35.5 (awslabs#3057)
  - build(deps): bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.1 to 3.9.0 (awslabs#3061)
  - Remove timestamp case from SnowflakeQueryStringBuilder (awslabs#2997)
  - build(deps): bump io.substrait.version from 0.65.0 to 0.66.0 (awslabs#3051)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.58.0 to 2.58.1 (awslabs#3059)
  - build(deps): bump org.postgresql:postgresql from 42.7.7 to 42.7.8 (awslabs#3063)
  - build(deps): bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.3 to 3.12.0 (awslabs#3062)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.4 to 4.9.6 (awslabs#3058)
  - build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.13 to 0.8.14 (awslabs#3060)
  - build(deps): bump net.sf.jt400:jt400 from 21.0.5 to 21.0.6 (awslabs#3053)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.50 to 20.00.00.51 (awslabs#3054)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.3 to 9.1.5 (awslabs#3056)
  - build(deps): bump org.bouncycastle:bcpkix-jdk18on from 1.81 to 1.82 (awslabs#3050)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.6 to 5.2.0 (awslabs#3052)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.114.1 to 1.115.0 (awslabs#3048)
  - build(deps): bump aws-sdk-v2.version from 2.34.5 to 2.35.0 (awslabs#3039)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.1.1 to 4.2 (awslabs#3037)
  - build(deps): bump aws-sdk.version from 1.12.791 to 1.12.792 (awslabs#3035)
  - build(deps): bump net.java.dev.jna:jna-platform from 5.17.0 to 5.18.1 (awslabs#3038)
  - build(deps-dev): bump log4j2Version from 2.25.1 to 2.25.2 (awslabs#3029)
  - build(deps): bump io.substrait.version from 0.52.0 to 0.65.0 (awslabs#3021)
  - build(deps): bump org.assertj:assertj-core from 3.27.4 to 3.27.6 (awslabs#3019)
  - build(deps): bump com.amazonaws:aws-lambda-java-core from 1.3.0 to 1.4.0 (awslabs#3020)
  - build(deps): bump net.java.dev.jna:jna from 5.17.0 to 5.18.1 (awslabs#3034)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib from 2.2.10 to 2.2.20 (awslabs#3027)
  - build(deps): bump org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0 (awslabs#3033)
  - build(deps): bump org.bouncycastle:bcprov-jdk18on from 1.81 to 1.82 (awslabs#3022)
  - build(deps): bump org.bouncycastle:bcutil-jdk18on from 1.81 to 1.82 (awslabs#3024)
  - build(deps): bump org.sonatype.central:central-publishing-maven-plugin from 0.8.0 to 0.9.0 (awslabs#3026)
  - build(deps): bump org.codehaus.mojo:license-maven-plugin from 2.6.0 to 2.7.0 (awslabs#3023)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.33.8 to 2.35.0 (awslabs#3040)
  - Add Support for OAuth in athena-saphana Connector (awslabs#2894)
  - build(deps): bump aws-actions/configure-aws-credentials from 4 to 5 (awslabs#2975)
  - build(deps): bump actions/setup-node from 4 to 5 (awslabs#2976)
  - [Neptune] Add doc details on how multi-valued properties are handled. (awslabs#2995)
  - build(deps): bump org.jetbrains.kotlin:kotlin-reflect from 2.2.10 to 2.2.20 (awslabs#3028)
  - build(deps): bump software.amazon.glue:schema-registry-serde from 1.1.24 to 1.1.25 (awslabs#3030)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.2.10 to 2.2.20 (awslabs#3031)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.49 to 20.00.00.50 (awslabs#3032)
  - build(deps): bump aws-sdk-v2.version from 2.34.3 to 2.34.5 (awslabs#3017)
  - Add Support for OAuth in athena-sqlserver Connector (awslabs#3006)
  - Add Support for OAuth in athena-synapse Connector (awslabs#2904)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.113.0 to 1.114.1 (awslabs#2979)
  - build(deps): bump org.apache.calcite.version from 1.39.0 to 1.40.0 (awslabs#2980)
  - build(deps): bump aws-sdk.version from 1.12.788 to 1.12.791 (awslabs#2981)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.4 to 5.1.5 (awslabs#2983)
  - build(deps): bump com.clickhouse:clickhouse-jdbc from 0.9.1 to 0.9.2 (awslabs#2985)
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.26.0 to 3.26.1 (awslabs#2987)
  - build(deps): bump org.yaml:snakeyaml from 2.4 to 2.5 (awslabs#2988)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.0.9 to 4.1 (awslabs#2998)
  - build(deps): bump aws-sdk-v2.version from 2.32.29 to 2.33.9 (awslabs#2999)
  - build(deps): bump org.apache.kafka:kafka-clients from 4.0.0 to 4.1.0 (awslabs#3000)
  - build(deps): bump surefire.failsafe.version from 3.5.3 to 3.5.4 (awslabs#3001)
  - build(deps): bump com.microsoft.azure:msal4j from 1.22.0 to 1.23.1 (awslabs#3002)
  - build(deps): bump org.apache.maven.plugins:maven-shade-plugin from 3.6.0 to 3.6.1 (awslabs#3003)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.55.0 to 2.57.0 (awslabs#3004)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.25.12 to 2.26.6 (awslabs#3012)
  - build(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.0 to 3.14.1 (awslabs#3011)
  - Fixing error messages to not leak sensitive info (awslabs#3008)
  - Include linked accounts option when querying metric_samples table. (awslabs#2922)
  - Updating Zookeeper to latest version 3.9.4 (awslabs#3005)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.29.3 to 4.32.0 (awslabs#2991)
  - Add serverless datalakegen2 support (awslabs#2973)
  - Abstract common OAuth handling and add OAuth support to Athena DataLake Gen2 Connector (awslabs#2932)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.32.29 to 2.33.4 (awslabs#2992)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.2 to 9.1.3 (awslabs#2993)
  - build(deps): bump io.lettuce:lettuce-core from 6.8.0.RELEASE to 6.8.1.RELEASE (awslabs#2994)
  - Hbase namespace issue (awslabs#2996)
github-actions bot pushed a commit to Jithendar12/aws-athena-query-federation that referenced this pull request Nov 29, 2025
Cut release 2025.47.1
94b0900 
  - Update release workflow for Java version builds
  - Enhance cut_release workflow for Java 11 and 17
  - wait for release branch and checkout
  - wait for release branch and checkout
  - Update runner and slug
  - Update GitHub Actions workflows to build with Java 11 and 17
  - Remove hard-coded Glue list-jobs --max-results 100 to find all Glue jobs (awslabs#3127)
  - Added unit tests in athena-synapse Connector (awslabs#2963)
  - Updating EncryptionKeyFactory to add overirde AWS request configuration in KMS calls made generate encryption key (awslabs#3103)
  - Fix epoch date conversion correctness issue when machine time zone is not in UTC (awslabs#3108)
  - Fix CVE-2025-48924: Upgrade Apache Commons Lang3 to 3.19.0 (awslabs#3100)
  - Revise Athena Federated Queries instructions in README (awslabs#3069)
  - fix snowflake QPT return empty result (awslabs#3106)
  - add view into oracle paginated query (awslabs#3107)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.32.1 to 4.33.0 (awslabs#3071)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.7 to 4.9.8 (awslabs#3076)
  - build(deps): bump org.apache.avro:avro from 1.12.0 to 1.12.1 (awslabs#3075)
  - Handle ResourceNotFoundException from Dynamodb as AthenaConnectorExce… (awslabs#3098)
  - Added unit tests for bigquery (awslabs#2950)
  - Update PostgreSQL engine version to 15.10 (awslabs#3099)
  - Add unit tests for athena-oracle. (awslabs#2836)
  - Adding support to use custom SecretManagerClient for Google Big Query (awslabs#2846)
  - Added unit tests for athena-cloudera-impala Connector (awslabs#2880)
  - added unit tests for athena-vertica. (awslabs#2783)
  - added unit tests for athena-redshift. (awslabs#2733)
  - Always include partition column when get-table-layout (awslabs#3045)
  - fix cloudwatch glue connection cfn template (awslabs#3013)
  - Added unit tests for JDBC module (awslabs#2732)
  - Added pagination for Db2 connector (awslabs#2772)
  - [Fix] Include default truststore path when passing JAVA_TOOL_OPTIONS for Java 17 image (awslabs#3007)
  - build(deps): bump com.google.guava:guava from 33.4.0-jre to 33.4.8-jre (awslabs#2728)
  - Handle KMS and DDB NotFoundExceptions by throwing AthenaConnectorException (awslabs#3064)
  - build(deps): bump aws-sdk-v2.version from 2.35.1 to 2.35.5 (awslabs#3047)
  - build(deps): bump io.confluent:kafka-avro-serializer from 8.0.0 to 8.0.2 (awslabs#3055)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.35.0 to 2.35.5 (awslabs#3057)
  - build(deps): bump org.apache.maven.plugins:maven-dependency-plugin from 3.8.1 to 3.9.0 (awslabs#3061)
  - Remove timestamp case from SnowflakeQueryStringBuilder (awslabs#2997)
  - build(deps): bump io.substrait.version from 0.65.0 to 0.66.0 (awslabs#3051)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.58.0 to 2.58.1 (awslabs#3059)
  - build(deps): bump org.postgresql:postgresql from 42.7.7 to 42.7.8 (awslabs#3063)
  - build(deps): bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.3 to 3.12.0 (awslabs#3062)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.4 to 4.9.6 (awslabs#3058)
  - build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.13 to 0.8.14 (awslabs#3060)
  - build(deps): bump net.sf.jt400:jt400 from 21.0.5 to 21.0.6 (awslabs#3053)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.50 to 20.00.00.51 (awslabs#3054)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.3 to 9.1.5 (awslabs#3056)
  - build(deps): bump org.bouncycastle:bcpkix-jdk18on from 1.81 to 1.82 (awslabs#3050)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.6 to 5.2.0 (awslabs#3052)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.114.1 to 1.115.0 (awslabs#3048)
  - build(deps): bump aws-sdk-v2.version from 2.34.5 to 2.35.0 (awslabs#3039)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.1.1 to 4.2 (awslabs#3037)
  - build(deps): bump aws-sdk.version from 1.12.791 to 1.12.792 (awslabs#3035)
  - build(deps): bump net.java.dev.jna:jna-platform from 5.17.0 to 5.18.1 (awslabs#3038)
  - build(deps-dev): bump log4j2Version from 2.25.1 to 2.25.2 (awslabs#3029)
  - build(deps): bump io.substrait.version from 0.52.0 to 0.65.0 (awslabs#3021)
  - build(deps): bump org.assertj:assertj-core from 3.27.4 to 3.27.6 (awslabs#3019)
  - build(deps): bump com.amazonaws:aws-lambda-java-core from 1.3.0 to 1.4.0 (awslabs#3020)
  - build(deps): bump net.java.dev.jna:jna from 5.17.0 to 5.18.1 (awslabs#3034)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib from 2.2.10 to 2.2.20 (awslabs#3027)
  - build(deps): bump org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0 (awslabs#3033)
  - build(deps): bump org.bouncycastle:bcprov-jdk18on from 1.81 to 1.82 (awslabs#3022)
  - build(deps): bump org.bouncycastle:bcutil-jdk18on from 1.81 to 1.82 (awslabs#3024)
  - build(deps): bump org.sonatype.central:central-publishing-maven-plugin from 0.8.0 to 0.9.0 (awslabs#3026)
  - build(deps): bump org.codehaus.mojo:license-maven-plugin from 2.6.0 to 2.7.0 (awslabs#3023)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.33.8 to 2.35.0 (awslabs#3040)
  - Add Support for OAuth in athena-saphana Connector (awslabs#2894)
  - build(deps): bump aws-actions/configure-aws-credentials from 4 to 5 (awslabs#2975)
  - build(deps): bump actions/setup-node from 4 to 5 (awslabs#2976)
  - [Neptune] Add doc details on how multi-valued properties are handled. (awslabs#2995)
  - build(deps): bump org.jetbrains.kotlin:kotlin-reflect from 2.2.10 to 2.2.20 (awslabs#3028)
  - build(deps): bump software.amazon.glue:schema-registry-serde from 1.1.24 to 1.1.25 (awslabs#3030)
  - build(deps): bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.2.10 to 2.2.20 (awslabs#3031)
  - build(deps): bump com.teradata.jdbc:terajdbc from 20.00.00.49 to 20.00.00.50 (awslabs#3032)
  - build(deps): bump aws-sdk-v2.version from 2.34.3 to 2.34.5 (awslabs#3017)
  - Add Support for OAuth in athena-sqlserver Connector (awslabs#3006)
  - Add Support for OAuth in athena-synapse Connector (awslabs#2904)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.113.0 to 1.114.1 (awslabs#2979)
  - build(deps): bump org.apache.calcite.version from 1.39.0 to 1.40.0 (awslabs#2980)
  - build(deps): bump aws-sdk.version from 1.12.788 to 1.12.791 (awslabs#2981)
  - build(deps): bump org.eclipse.rdf4j:rdf4j-repository-sparql from 5.1.4 to 5.1.5 (awslabs#2983)
  - build(deps): bump com.clickhouse:clickhouse-jdbc from 0.9.1 to 0.9.2 (awslabs#2985)
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.26.0 to 3.26.1 (awslabs#2987)
  - build(deps): bump org.yaml:snakeyaml from 2.4 to 2.5 (awslabs#2988)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 4.0.9 to 4.1 (awslabs#2998)
  - build(deps): bump aws-sdk-v2.version from 2.32.29 to 2.33.9 (awslabs#2999)
  - build(deps): bump org.apache.kafka:kafka-clients from 4.0.0 to 4.1.0 (awslabs#3000)
  - build(deps): bump surefire.failsafe.version from 3.5.3 to 3.5.4 (awslabs#3001)
  - build(deps): bump com.microsoft.azure:msal4j from 1.22.0 to 1.23.1 (awslabs#3002)
  - build(deps): bump org.apache.maven.plugins:maven-shade-plugin from 3.6.0 to 3.6.1 (awslabs#3003)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.55.0 to 2.57.0 (awslabs#3004)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.25.12 to 2.26.6 (awslabs#3012)
  - build(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.0 to 3.14.1 (awslabs#3011)
  - Fixing error messages to not leak sensitive info (awslabs#3008)
  - Include linked accounts option when querying metric_samples table. (awslabs#2922)
  - Updating Zookeeper to latest version 3.9.4 (awslabs#3005)
  - build(deps): bump com.google.protobuf:protobuf-bom from 4.29.3 to 4.32.0 (awslabs#2991)
  - Add serverless datalakegen2 support (awslabs#2973)
  - Abstract common OAuth handling and add OAuth support to Athena DataLake Gen2 Connector (awslabs#2932)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.32.29 to 2.33.4 (awslabs#2992)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 9.1.2 to 9.1.3 (awslabs#2993)
  - build(deps): bump io.lettuce:lettuce-core from 6.8.0.RELEASE to 6.8.1.RELEASE (awslabs#2994)
  - Hbase namespace issue (awslabs#2996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christov christov christov approved these changes

@aimethed aimethed aimethed approved these changes

+1 more reviewer

@Jithendar12 Jithendar12 Jithendar12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@christov christov

@aimethed aimethed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ritiktrianz @Jithendar12 @christov @aimethed