fix(core): remove zstd WriteBuf dependency for byte slice conversion #1295
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace res_bytes.as_slice() with idiomatic &res_bytes[..] to avoid name collision with new [T]::as_slice() method added in Rust nightly (rust-lang/rust#145933, merged 2025-12-18). Issue observed in nightly build checks for PR awslabs#1293. The WriteBuf trait from zstd was only imported to provide as_slice() through its impl for [u8], which is unnecessary coupling. Using slice syntax is more idiomatic and doesn't require external trait imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Description of changes
Replace
res_bytes.as_slice()with idiomatic&res_bytes[..]to avoid name collision with new [T]::as_slice() method added in Rust nightly (rust-lang/rust#145933, merged 2025-12-18).Issue observed in nightly build checks for PR #1293.
The WriteBuf trait from zstd was only imported to provide as_slice() through its impl for [u8], which is unnecessary coupling. Using slice syntax is more idiomatic and doesn't require external trait imports.
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.