Expand `str_as_str` to more types #145933

GrigorenkoPV · 2025-08-27T14:41:55Z

Tracking issue: #130366
ACP: rust-lang/libs-team#643

This PR expands str_from_str feature and adds analogous methods to more types. Namely:

&CStr
&[T], &mut [T]
&OsStr
&Path
&ByteStr, &mut ByteStr (tracking issue: Tracking Issue for ByteStr/ByteString #134915) (technically was not part of ACP)

rustbot · 2025-08-27T14:41:59Z

Error: Label needs-acp can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

rustbot · 2025-11-11T20:14:22Z

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GrigorenkoPV · 2025-11-11T20:14:38Z

@rustbot label -S-waiting-on-ACP +T-libs
@rustbot ready
r?

rustbot · 2025-11-11T20:15:02Z

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

joboet · 2025-12-02T16:54:00Z

Looks fine, but I'd also add &mut variants for Path, OsStr and CStr if that's fine for T-libs-api.

r? libs-api

bors · 2025-12-18T08:15:28Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Support recursive delegation #150024

bors · 2025-12-18T08:15:29Z

📌 Commit 48f7f31 has been approved by Amanieu

It is now in the queue for this repository.

…uwer Rollup of 5 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-12-18T08:19:29Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Expand `str_as_str` to more types Tracking issue: #130366 ACP: rust-lang/libs-team#643 This PR expands `str_from_str` feature and adds analogous methods to more types. Namely: - `&CStr` - `&[T]`, `&mut [T]` - `&OsStr` - `&Path` - `&ByteStr`, `&mut ByteStr` (tracking issue: #134915) (technically was not part of ACP)

bors · 2025-12-18T08:26:00Z

⌛ Testing commit 48f7f31 with merge 6bf7d69...

bors · 2025-12-18T08:33:08Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-12-18T09:25:37Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

…uwer Rollup of 5 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) r? `@ghost` `@rustbot` modify labels: rollup

JonathanBrouwer · 2025-12-18T09:54:14Z

@bors retry (Spurious)

…uwer Rollup of 5 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) r? `@ghost` `@rustbot` modify labels: rollup

…nieu Expand `str_as_str` to more types Tracking issue: rust-lang#130366 ACP: rust-lang/libs-team#643 This PR expands `str_from_str` feature and adds analogous methods to more types. Namely: - `&CStr` - `&[T]`, `&mut [T]` - `&OsStr` - `&Path` - `&ByteStr`, `&mut ByteStr` (tracking issue: rust-lang#134915) (technically was not part of ACP)

…uwer Rollup of 11 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #149925 (`cfg_select!`: parse unused branches) - #150022 (Generate macro expansion for rust compiler crates docs) - #150024 (Support recursive delegation) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable)) - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser) - #150126 (Subtree sync for rustc_codegen_cranelift) Failed merges: - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup

…uwer Rollup of 12 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #149925 (`cfg_select!`: parse unused branches) - #149952 (Suggest struct pattern when destructuring Range with .. syntax) - #150022 (Generate macro expansion for rust compiler crates docs) - #150024 (Support recursive delegation) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable)) - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser) - #150126 (Subtree sync for rustc_codegen_cranelift) Failed merges: - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145933 - GrigorenkoPV:thing_as_thing, r=Amanieu Expand `str_as_str` to more types Tracking issue: #130366 ACP: rust-lang/libs-team#643 This PR expands `str_from_str` feature and adds analogous methods to more types. Namely: - `&CStr` - `&[T]`, `&mut [T]` - `&OsStr` - `&Path` - `&ByteStr`, `&mut ByteStr` (tracking issue: #134915) (technically was not part of ACP)

Replace res_bytes.as_slice() with idiomatic &res_bytes[..] to avoid name collision with new [T]::as_slice() method added in Rust nightly (rust-lang/rust#145933, merged 2025-12-18). Issue observed in nightly build checks for PR awslabs#1293. The WriteBuf trait from zstd was only imported to provide as_slice() through its impl for [u8], which is unnecessary coupling. Using slice syntax is more idiomatic and doesn't require external trait imports.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2025

GrigorenkoPV mentioned this pull request Aug 27, 2025

str::as_str but for CStr, OsStr, Path, and [T] rust-lang/libs-team#643

Closed

rustbot added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2025

GrigorenkoPV marked this pull request as draft August 27, 2025 21:38

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025

Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 19, 2025

{CStr,OsStr,Path}::as_$1

a197ebd

GrigorenkoPV force-pushed the thing_as_thing branch from 05090a9 to 2a20389 Compare November 11, 2025 20:09

GrigorenkoPV changed the title ~~thing_as_thing~~ Expand str_as_str to more types Nov 11, 2025

GrigorenkoPV marked this pull request as ready for review November 11, 2025 20:14

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2025

rustbot assigned joboet Nov 11, 2025

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Nov 11, 2025

GrigorenkoPV mentioned this pull request Nov 11, 2025

Tracking Issue for str::as_str() & friends #130366

Open

6 tasks

[T]::as_[mut_]slice

4e5ce74

GrigorenkoPV force-pushed the thing_as_thing branch from 2a20389 to 18ebcd9 Compare November 11, 2025 20:40

ByteStr::as_[mut_]byte_str

48f7f31

GrigorenkoPV force-pushed the thing_as_thing branch from 18ebcd9 to 48f7f31 Compare November 11, 2025 20:46

rustbot assigned Amanieu and unassigned joboet Dec 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

JonathanBrouwer mentioned this pull request Dec 18, 2025

Rollup of 11 pull requests #150132

Closed

JonathanBrouwer mentioned this pull request Dec 18, 2025

Rollup of 12 pull requests #150135

Merged

bors merged commit 663d843 into rust-lang:main Dec 18, 2025
11 of 12 checks passed

rustbot added this to the 1.94.0 milestone Dec 18, 2025

GrigorenkoPV deleted the thing_as_thing branch December 21, 2025 14:00

chessbyte mentioned this pull request Dec 21, 2025

fix(core): remove zstd WriteBuf dependency for byte slice conversion awslabs/llrt#1295

Open

5 tasks

Uh oh!

Expand str_as_str to more types #145933

Expand str_as_str to more types #145933

Conversation

GrigorenkoPV commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 27, 2025

Uh oh!

rustbot commented Nov 11, 2025

Uh oh!

GrigorenkoPV commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 11, 2025

Uh oh!

joboet commented Dec 2, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

rust-log-analyzer commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

rust-log-analyzer commented Dec 18, 2025

Uh oh!

JonathanBrouwer commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Expand `str_as_str` to more types #145933

Expand `str_as_str` to more types #145933

GrigorenkoPV commented Aug 27, 2025 •

edited

Loading

GrigorenkoPV commented Nov 11, 2025 •

edited

Loading