Repository navigation
build: raise the Bun floor to 1.4.0 and drop the bun:sqlite fallback - #2559
Merged
Merged
Conversation
- Pin bun-version: 1.4.0 across test.yml and publish.yml and move every workspace engines field to bun >=1.4.0. - Hold @types/bun at 1.3.14: bun-types 1.4.0 declares on/off/once for its memoryPressure event directly on NodeJS.Process, which hides the inherited EventEmitter overloads and breaks process.off(...) under tsc. - Bun 1.4.0 ships node:sqlite (oven-sh/bun#32498), so the SQLite resource selectors load it exclusively; the bun:sqlite fallback and the test fixture's Bun branch are removed, and the CI contract test now rejects reintroducing either. - Update AGENTS.md, DEV_SETUP.md, README.md, docs/ci.md, the coding-agent docs, and the coding-agent changelog to match. Assistant-model: Claude Fable 5
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…1.4.0 Bun 1.4.0 self-reports Node-compat 26.x, so 'bunx --bun mintlify' now trips mintlify's Node 25+ refusal; run it through npx against the job's pinned Node 22 LTS instead. On Windows, Bun 1.4.0's node:sqlite releases file locks lazily after close(), so the Bun-runtime smoke script's cleanup rmSync gets bounded retries and no longer fails the test over cleanup. Assistant-model: Claude Fable 5
flora131
enabled auto-merge
August 21, 2026 04:28
npx chdirs to the nearest package root (packages/coding-agent), so mintlify resolves docs.json one directory up and fails with 'must be run in a directory where a docs.json file exists'. Plain bunx preserves the step's working-directory, and without --bun the CLI wrapper's spawned 'node' child resolves to the job's pinned Node 22 LTS instead of Bun's self-reported Node-compat 26.x. Both failure modes and the fix verified on a Linux + Node 22 + Bun 1.4.0 container. Assistant-model: Claude Fable 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the repository's pinned Bun from 1.3.14 to 1.4.0 and removes the
bun:sqlitefallback that only existed because older Bun lackednode:sqlite.Changes
bun-version: 1.4.0in all nine spots acrosstest.ymlandpublish.yml; move every workspaceenginesfield tobun >=1.4.0(lockfile andnpm-shrinkwrap.jsonregenerated).node:sqlite(node:sqlite: implement the module and pass the Node v26.3.0 test suite oven-sh/bun#32498), soresource-selectors.tsloads it exclusively. Thebun:sqlitefallback and the test fixture's Bun branch are removed, and the CI contract test now rejects reintroducing either.@types/bunat 1.3.14: bun-types 1.4.0 declareson/off/oncefor its newmemoryPressureevent directly onNodeJS.Process, which hides the inheritedEventEmitteroverloads and breaks everyprocess.off("SIGINT"|"unhandledRejection", ...)call undertsc(24 errors, including upstream-copied coding-agent code). Documented in AGENTS.md with the bump condition.Notes
npm run checkgreen (biome, both typecheck passes, shrinkwrap), fulltest:ci-contractssuite 47/47, and the four SQLite-selector test files 47/47.bun:sqlitestill exists in Bun itself; the one test that uses it as a fixture builder under a real Bun child keeps working unchanged.node:sqliteloads under Bun 1.4.0 (typeof DatabaseSync === "function").Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
Updates the supported Bun runtime to 1.4.0 across package metadata, CI, release workflows, and developer documentation. SQLite resource selectors now use
node:sqliteon both supported runtimes. The exercised selector workflow successfully created, read, updated, and searched SQLite data under Bun 1.4.0, and the focused selector and CI configuration suites passed.Confidence Score: 5/5
No blocking failure remains.
No accepted blocking findings remain. The supported Bun 1.4.0 SQLite selector path and its configuration contracts completed successfully.
What T-Rex did
Reviews (3): Last reviewed commit: "fix(ci): run mintlify through plain bunx..." | Re-trigger Greptile