Skip to content

build: raise the Bun floor to 1.4.0 and drop the bun:sqlite fallback - #2559

Merged
flora131 merged 3 commits into
mainfrom
build/bun-1.4.0
Aug 21, 2026
Merged

flora131 merged 3 commits into
mainfrom
build/bun-1.4.0

Conversation

@flora131

@flora131 flora131 commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Upgrades the repository's pinned Bun from 1.3.14 to 1.4.0 and removes the bun:sqlite fallback that only existed because older Bun lacked node:sqlite.

Changes

  • Pin bun-version: 1.4.0 in all nine spots across test.yml and publish.yml; move every workspace engines field to bun >=1.4.0 (lockfile and npm-shrinkwrap.json regenerated).
  • Bun 1.4.0 ships node:sqlite (node:sqlite: implement the module and pass the Node v26.3.0 test suite oven-sh/bun#32498), so resource-selectors.ts loads it exclusively. The bun:sqlite fallback and the test fixture's Bun branch are removed, and the CI contract test now rejects reintroducing either.
  • Hold @types/bun at 1.3.14: bun-types 1.4.0 declares on/off/once for its new memoryPressure event directly on NodeJS.Process, which hides the inherited EventEmitter overloads and breaks every process.off("SIGINT"|"unhandledRejection", ...) call under tsc (24 errors, including upstream-copied coding-agent code). Documented in AGENTS.md with the bump condition.
  • Docs updated: AGENTS.md, DEV_SETUP.md, README.md, docs/ci.md, coding-agent quickstart/development docs, and the coding-agent changelog.

Notes

  • Validated locally: npm run check green (biome, both typecheck passes, shrinkwrap), full test:ci-contracts suite 47/47, and the four SQLite-selector test files 47/47.
  • bun:sqlite still exists in Bun itself; the one test that uses it as a fixture builder under a real Bun child keeps working unchanged.
  • Verified node:sqlite loads under Bun 1.4.0 (typeof DatabaseSync === "function").

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Greptile Summary

Updates the supported Bun runtime to 1.4.0 across package metadata, CI, release workflows, and developer documentation. SQLite resource selectors now use node:sqlite on both supported runtimes. The exercised selector workflow successfully created, read, updated, and searched SQLite data under Bun 1.4.0, and the focused selector and CI configuration suites passed.

Confidence Score: 5/5

No blocking failure remains.

No accepted blocking findings remain. The supported Bun 1.4.0 SQLite selector path and its configuration contracts completed successfully.

T-Rex T-Rex Logs

What T-Rex did

  • The SQLite selector validation script was run against the production readSqliteSelector, writeSqliteSelector, and searchSqliteSelector flows, and it showed Bun 1.3.14 could not resolve node:sqlite while Bun 1.4.0 exposed the SQLite API, read the Ada row, updated it to Grace with boolean normalization, and returned the updated row via search.
  • The focused resource-selector test suite passed entirely under Bun 1.4.0, with all 32 tests succeeding.
  • The CI Bun configuration contracts suite also passed, with all 47 tests succeeding.
  • The exact script source and command outputs were captured for review.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "fix(ci): run mintlify through plain bunx..." | Re-trigger Greptile

- Pin bun-version: 1.4.0 across test.yml and publish.yml and move every
  workspace engines field to bun >=1.4.0.
- Hold @types/bun at 1.3.14: bun-types 1.4.0 declares on/off/once for its
  memoryPressure event directly on NodeJS.Process, which hides the
  inherited EventEmitter overloads and breaks process.off(...) under tsc.
- Bun 1.4.0 ships node:sqlite (oven-sh/bun#32498), so the SQLite resource
  selectors load it exclusively; the bun:sqlite fallback and the test
  fixture's Bun branch are removed, and the CI contract test now rejects
  reintroducing either.
- Update AGENTS.md, DEV_SETUP.md, README.md, docs/ci.md, the coding-agent
  docs, and the coding-agent changelog to match.

Assistant-model: Claude Fable 5
@mintlify

mintlify Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
bastani 🟢 Ready View Preview Aug 21, 2026, 4:04 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

…1.4.0

Bun 1.4.0 self-reports Node-compat 26.x, so 'bunx --bun mintlify' now
trips mintlify's Node 25+ refusal; run it through npx against the job's
pinned Node 22 LTS instead. On Windows, Bun 1.4.0's node:sqlite releases
file locks lazily after close(), so the Bun-runtime smoke script's
cleanup rmSync gets bounded retries and no longer fails the test over
cleanup.

Assistant-model: Claude Fable 5
@flora131
flora131 enabled auto-merge August 21, 2026 04:28
npx chdirs to the nearest package root (packages/coding-agent), so
mintlify resolves docs.json one directory up and fails with 'must be run
in a directory where a docs.json file exists'. Plain bunx preserves the
step's working-directory, and without --bun the CLI wrapper's spawned
'node' child resolves to the job's pinned Node 22 LTS instead of Bun's
self-reported Node-compat 26.x. Both failure modes and the fix verified
on a Linux + Node 22 + Bun 1.4.0 container.

Assistant-model: Claude Fable 5
@flora131
flora131 merged commit 7c6c99e into main Aug 21, 2026
17 checks passed
@lavaman131
lavaman131 deleted the build/bun-1.4.0 branch October 27, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant