Repository navigation
build: raise the Bun runtime floor to 1.4.2 - #2898
Merged
Merged
Conversation
Upgrade compatible Bun types to 1.4.1; 1.4.2 types are not yet published. Keep historical evidence and Windows-hosted compilation safeguards intact. Assistant-model: Grok 4.6
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the active Bun runtime pins to 1.4.2 and existing minimum engine requirements to >=1.4.2. This is a focused mechanical upgrade, following the runtime/metadata/types approach in #2559.
Changes
@types/bunfrom 1.3.14 to 1.4.1.@types/bun@1.4.2returned registry E404 during validation. The published 1.4.1 package pins matchingbun-typesdeclarations and restores the Process listener overloads needed by the repository. Both typecheck passes succeed; the exception is documented inAGENTS.md.Validation
Implementation and independent reviewer logs were inspected for signed commit
2e7bbb619184ed2e2313fcfbd734670479375034:npm ci --ignore-scriptsandnpm run buildnpm run checknpm run test:ci-contractsnpm run test:unit -- test/unit/build-binaries-platform-packaging.test.ts test/unit/windows-startup-summary.test.tsnode:sqlitebun run scripts/probe-windows-bytecode.ts --outdir /tmp/bun-risk-windows-probe0x8664and ARM64 PE0xaa64git diff --check origin/mainThe goal ledger is complete with three independent approvals and no findings. Required suite results above come from the inspected implementation/reviewer logs, not a new full-suite run during PR preparation. The final-stage
qlty check --upstream origin/mainselected no modified files, so it adds no lint coverage.Notes
--skip-windows, smoke jobs and all CI coverage remain intact. No Windows speedup or runtime compatibility claim is added.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
The Bun runtime floor is consistently raised to 1.4.2 across CI and release workflows, workspace engine declarations, lock metadata, and Windows bytecode and benchmark contracts. No issues requiring changes were found.
Confidence Score: 5/5
Safe to merge.
The completed contract check confirmed the previous 1.4.0 floor and the updated 1.4.2 floor across all checked workflow, package, metadata, and Windows assertion paths. No actionable issues were identified.
Files Needing Attention: None.
What T-Rex did
Reviews (1): Last reviewed commit: "build: raise the Bun runtime floor to 1...." | Re-trigger Greptile