Scala 2.12 support #300

gkossakowski · 2017-10-11T23:36:43Z

Adds support for Scala 2.12.3. In the history, you can see that I tested Scala 2.12.4 nightly builds to verify the issue with the flat classpath caching.

Notes:

Scala 2.12.3 has a bug related to classpath caching that breaks bazel's incremental compilation when scalac worker is enabled: [discussion] Scala 2.12 support #251 (comment)
this PR disables the jmh test, the rule doesn't support Java 8 bytecode, see jmh rules uses jmh hook that doesn't support Java 8 bytecode #295

Bump dependencies to versions that support Scala 2.12.

They swapped the logger interface and now there's a different went to silence the logging.

Newer versions of scalatest have scalactic as a dependency. Let bazel know about it and add its a transitive dep.

Add a missing dependency on Twitter's util_core from scrooge rule

This makes the code to compile again on my laptop.

The 031e73c restructured java_commmon rule and dropped both `transitive_compile_time_jars` and `transitive_runtime_jars` from that rule. Let's sync scala.bzl with that change.

Switch to a recent nightly build that has a fix for the flat classpath caching bug that is breaking bazel's incremental compilation when worker is enabled. See bazel-contrib#251 (comment) for the details of the bug.

Fix version numbers of ScalaPB dependencies to be Scala 2.12-specific. # Conflicts: # scala/scala.bzl

Link to an issue explaining the jmh failure is related to Java 8 and not directly caused by the Scala 2.12.

For mysterious reasons, the hash has changed for a build that should be unique. A sign that relying on nightly builds is risky. Yolo for now, though.

This reverts commit 55fd807. Switch back to 2.12.3 until 2.12.4 is released. This will make the testing easier for projects that rely on compiler plugins.

See bazel-contrib#295 for why it's failing.

bazel-io · 2017-10-11T23:36:45Z

Can one of the admins verify this patch?

googlebot · 2017-10-11T23:36:53Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

johnynek · 2017-10-11T23:57:49Z

adding CLA yes since Grzeg is at Stripe and we have signed the CLA.

ittaiz

Looks good in general. Well done.

ittaiz · 2017-10-12T04:37:16Z

twitter_scrooge/twitter_scrooge.bzl

@@ -9,7 +9,7 @@ load("//scala:scala.bzl",
 def twitter_scrooge():
  native.maven_server(
    name = "twitter_scrooge_maven_server",
-    url = "http://mirror.bazel.build/repo1.maven.org/maven2/",
+    url = "http://repo1.maven.org/maven2/",


Why can't we use the Bazel mirror?

i can't remember the reason to switch, switched back

ittaiz · 2017-10-12T04:38:13Z

WORKSPACE

@@ -23,23 +23,23 @@ specs2_junit_repositories()
 # test adding a scala jar:
 maven_jar(
  name = "com_twitter__scalding_date",
-  artifact = scala_mvn_artifact("com.twitter:scalding-date:0.16.0-RC4"),
-  sha1 = "659eb2d42945dea37b310d96af4e12bf83f54d14"
+  artifact = scala_mvn_artifact("com.twitter:scalding-date:0.17.0"),


Can we do the version upgrades in master to minimize the diff?

ittaiz · 2017-10-12T04:40:53Z

src/java/io/bazel/rulesscala/scalac/BUILD

@@ -6,6 +6,12 @@ java_binary(
        "ScalacProcessor.java",
    ],
    main_class = "io.bazel.rulesscala.scalac.ScalaCInvoker",
+    # this probably should be set globally for the entire rules_scala


Maybe this needs to be in the scala.bzl?
If so we need to also test that the user gets a clear error message when they request a lower version.
And also they can request a higher version and it's ok

Is there a pattern of enforcing minimal Java version on clients of the rule?

johnynek · 2017-10-12T17:08:12Z

WORKSPACE

@@ -23,23 +23,23 @@ specs2_junit_repositories()
 # test adding a scala jar:
 maven_jar(
  name = "com_twitter__scalding_date",
-  artifact = scala_mvn_artifact("com.twitter:scalding-date:0.16.0-RC4"),
-  sha1 = "659eb2d42945dea37b310d96af4e12bf83f54d14"
+  artifact = scala_mvn_artifact("com.twitter:scalding-date:0.17.0"),


johnynek · 2017-10-12T17:09:06Z

specs2/specs2.bzl

@@ -4,36 +4,36 @@ def specs2_repositories():

  native.maven_jar(
      name = "io_bazel_rules_scala_org_specs2_specs2_core",
-      artifact = "org.specs2:specs2-core_2.11:" + specs2_version(),
-      sha1 = "495bed00c73483f4f5f43945fde63c615d03e637",
+      artifact = "org.specs2:specs2-core_2.12:" + specs2_version(),


if we used scala_mvn_artifact we wouldn't have this change here.

I went wholesale on this in #303

johnynek · 2017-10-12T17:09:30Z

scala_proto/scala_proto.bzl

@@ -81,8 +81,8 @@ def scala_proto_repositories():

    native.maven_jar(
        name = "scala_proto_rules_scalapb_lenses",
-        artifact = "com.trueaccord.lenses:lenses_2.11:0.4.12",
-        sha1 = "c5fbf5b872ce99d9a16d3392ccc0d15a0e43d823",
+        artifact = "com.trueaccord.lenses:lenses_2.12:0.4.12",


if we used scala_mvn_artifact here we wouldn't have this change and others in the file.

gkossakowski · 2017-10-12T22:03:42Z

I'm going to reopen this from my Stripe account to remove the cla check error. Apologies scattered review feedback.

googlebot · 2017-10-12T22:03:50Z

CLAs look good, thanks!

johnynek · 2017-10-14T02:05:34Z

I'm going to close this in favor of #304

gkk-stripe added 14 commits September 8, 2017 11:02

Scala 2.12 updates

705032d

Bump dependencies to versions that support Scala 2.12.

Fix incompatible scrooge api change.

e4276a9

They swapped the logger interface and now there's a different went to silence the logging.

Add scalactic as a transitive dep of scalatest

30c0bdc

Newer versions of scalatest have scalactic as a dependency. Let bazel know about it and add its a transitive dep.

Add a missing dependency on util_core from scrooge rule

c23c422

Add a missing dependency on Twitter's util_core from scrooge rule

Set -source 1.8 and -target 1.8 javac options

18c54ee

This makes the code to compile again on my laptop.

Merge remote-tracking branch 'origin/master' into gkk-scala-2.12

cd4d3d6

Remove dropped args when calling java_common.create_provider

bca505c

The 031e73c restructured java_commmon rule and dropped both `transitive_compile_time_jars` and `transitive_runtime_jars` from that rule. Let's sync scala.bzl with that change.

Upgrade to Scala 2.12.3

055b33e

Switch to Scala nightly build with classpath caching fix

55fd807

Switch to a recent nightly build that has a fix for the flat classpath caching bug that is breaking bazel's incremental compilation when worker is enabled. See bazel-contrib#251 (comment) for the details of the bug.

Merge remote-tracking branch 'origin/master' into gkk-scala-2.12

a2895c1

Fix version numbers of ScalaPB dependencies to be Scala 2.12-specific. # Conflicts: # scala/scala.bzl

Crash jmh with an explanation why it doesn't work

31e8e1f

Link to an issue explaining the jmh failure is related to Java 8 and not directly caused by the Scala 2.12.

Upgrade the hash of the nightly build

5ef84d9

For mysterious reasons, the hash has changed for a build that should be unique. A sign that relying on nightly builds is risky. Yolo for now, though.

Revert "Switch to Scala nightly build with classpath caching fix"

1c8cb77

This reverts commit 55fd807. Switch back to 2.12.3 until 2.12.4 is released. This will make the testing easier for projects that rely on compiler plugins.

Disable jmh test

f903c9d

See bazel-contrib#295 for why it's failing.

googlebot added the cla: no label Oct 11, 2017

johnynek added cla: yes and removed cla: no labels Oct 11, 2017

ittaiz suggested changes Oct 12, 2017

View reviewed changes

johnynek reviewed Oct 12, 2017

View reviewed changes

gkk-stripe mentioned this pull request Oct 12, 2017

Scala 2.12 support #304

Merged

johnynek closed this Oct 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scala 2.12 support #300

Scala 2.12 support #300

gkossakowski commented Oct 11, 2017

bazel-io commented Oct 11, 2017

googlebot commented Oct 11, 2017

johnynek commented Oct 11, 2017

ittaiz left a comment

ittaiz Oct 12, 2017

gkossakowski Oct 12, 2017

ittaiz Oct 12, 2017

johnynek Oct 12, 2017

gkossakowski Oct 12, 2017

ittaiz Oct 12, 2017

gkossakowski Oct 12, 2017

johnynek Oct 12, 2017

johnynek Oct 12, 2017

gkossakowski Oct 12, 2017

johnynek Oct 12, 2017

gkossakowski commented Oct 12, 2017

googlebot commented Oct 12, 2017

johnynek commented Oct 14, 2017

Scala 2.12 support #300

Scala 2.12 support #300

Conversation

gkossakowski commented Oct 11, 2017

bazel-io commented Oct 11, 2017

googlebot commented Oct 11, 2017

johnynek commented Oct 11, 2017

ittaiz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkossakowski commented Oct 12, 2017

googlebot commented Oct 12, 2017

johnynek commented Oct 14, 2017