Dependencies cleanup #303
Merged
Dependencies cleanup #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move scala_version and scala_mvn_artifact from scala.bzl to scala_cross_version.bzl. This will allow for specs2.bzl to depend on these functions without introducing a cycle. Before this refactor, the cycle is: scala.bzl -> specs2.bzl -> specs2.bzl
Migrate most of occurences of Scala dependencies with _2.11 suffix hardcoded to use scala_mvn_artifact that abstract Scala's major version. With this change we get down to just a few remaining hardcoded _2.11 uses: $ ag _2.11 scala/scala.bzl 980: jars = ["lib/scala-xml_2.11-1.0.5.jar"], 986: jars = ["lib/scala-parser-combinators_2.11-1.0.4.jar"], 1021: url = "http://mirror.bazel.build/oss.sonatype.org/content/groups/public/org/scalatest/scalatest_2.11/2.2.6/scalatest_2.11-2.2.6.jar", specs2/specs2_junit.bzl 10: name = "io_bazel_rules_scala_org_specs2_specs2_junit_2_11", 14: native.bind(name = 'io_bazel_rules_scala/dependency/specs2/specs2_junit', actual = '@io_bazel_rules_scala_org_specs2_specs2_junit_2_11//jar') test/aspect/aspect.bzl 55: "@io_bazel_rules_scala_org_specs2_specs2_junit_2_11//jar:jar",
|
Can one of the admins verify this patch? |
Closed
johnynek
reviewed
Oct 12, 2017
| @@ -1,4 +1,5 @@ | |||
| load("//scala:scala.bzl", | |||
| "scala_mvn_artifact", | |||
There was a problem hiding this comment.
how does this build? I thought you moved this to a new file?
There was a problem hiding this comment.
I was puzzled by this too. It looks like if you load a symbol in bzl files, it's available to both you and downstream bzl files. Not sure if it's intended that way.
This is a version that has both 2.11 and 2.12 releases available so will make the diff between 2.11 and 2.12 smaller.
gkk-stripe
force-pushed
the
gkk-deps-cleanup
branch
from
5601ba3 to
a9c6a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala_mvn_artifactSee commits for details.