WIP: test with all_incompatible_changes #452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2018
|
@johnynek thanks for breaking it down! it's really helpful |
|
We can close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an attempt to address #430
but of course, I broke things.
It seems related to scala_binary somehow. I can build items in test, but anything that itself uses a scala binary seems broken. So tut, protobuf and thrift are broken.
I tried to just translate to the non-deprecated form, and it runs, but it just doesn't work, which is pretty hard to debug.
I'd welcome any help here and certainly a review would be great.
cc @iphydf @ittaiz