Use some more non deprecated APIs #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay @ittaiz I think this is ready to go. I think we are using all the modern action APIs in scala.bzl now. I think I realized my problem. In #452 I didn't set the wrapper file to be executable, so I think it wouldn't run. I guess previously that was the default. I didn't verify that, but that here: you can see that I didn't set If this is green on all the CI checks, we can merge and follow up with the depset changes. Then, perhaps we can turn on the all incompatible changes flag in CI. |
|
cc @andyscott can you take a look? |
|
LGTM |
andyscott
approved these changes
Mar 31, 2018
ianoc-stripe
pushed a commit
to ianoc-stripe/rules_scala
that referenced
this pull request
Jun 12, 2018
* Use some more non deprecated APIs * Use actions.run for scalac * fix a few more old APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #452 in the scala.bzl part. Not all of the changes. I want to see them pass on CI, since the laptop I am using is a bit slow. They seem to pass, but to be extra sure we might want a clean build from travis.