flatten depset of transitive proto paths (currently broken accumulation) #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
approved these changes
May 20, 2018
|
Those were my exact thoughts :)
Thanks for merging.
…On Sun, 20 May 2018 at 19:03 P. Oscar Boykin ***@***.***> wrote:
Merged #506 <#506>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#506 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF2VGlCNCYKz2TLOid8h0nWZAmx1_ks5t0ZPWgaJpZM4UGE1N>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnynek #454 broke transitive proto paths. Because the test was not in CI (requires bazel 0.12.0 which we didn't have until yesterday) we didn't notice it.
I'm now running the test and fixed the issue.
This is a serious blocker for us so if you can take a look and sign off I'd appreciate it :)