Skip to content

flatten depset of transitive proto paths (currently broken accumulation) #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2018
Merged

flatten depset of transitive proto paths (currently broken accumulation) #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scala_proto/scala_proto.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def _gen_proto_srcjar_impl(ctx):
# Command line args to worker cannot be empty so using padding
flags_arg = "-" + ",".join(ctx.attr.flags),
# Command line args to worker cannot be empty so using padding
packages = "-" + ":".join(transitive_proto_paths)
packages = "-" + ":".join(depset(transitive = transitive_proto_paths).to_list())
)
argfile = ctx.actions.declare_file("%s_worker_input" % ctx.label.name, sibling = ctx.outputs.srcjar)
ctx.actions.write(output=argfile, content=worker_content)
Expand Down
1 change: 1 addition & 0 deletions test_rules_scala.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,3 +805,4 @@ $runner test_scala_import_library_passes_labels_of_direct_deps
$runner java_toolchain_javacopts_are_used
$runner bazel run test/src/main/scala/scala/test/classpath_resources:classpath_resource
$runner test_scala_classpath_resources_expect_warning_on_namespace_conflict
$runner bazel build //test_expect_failure/proto_source_root/... --strict_proto_deps=off