-
Notifications
You must be signed in to change notification settings - Fork 482
Tweak import macro bootstrap to trick rust analyzer aspect #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The We intentionally omitted the docs attributes so this rule doesn't pollute our docs pages. But now that I'm thinking about it it's not the presence of docs, but explicit configuration in bzl files in //docs that matters for what is shown on docs pages. Therefore I'll add docs in the morning :) |
Sweet! I'll await docs |
@hlopko is there anything more than docs this is waiting on? |
That, tests, and also I think I'll re-do the PR to add support for aliases into rust analyzer tooling (currently alias is not traversed), and then I'm change the transitioning rules to mimic alias (name of the attribute will be |
d8d2f12
to
4c279b0
Compare
This is now ready for another review, please take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just some nits 😅
I'm not entirely sure what happened here: https://buildkite.com/bazel/rules-rust-rustlang/builds/5705#1fa56c67-7d6d-407a-b50c-aa78c5327cf1 |
Co-authored-by: UebelAndre <[email protected]>
Co-authored-by: UebelAndre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
In #1166 we discovered that rust analyzer aspect doesn't understand the
_with_import_macro_bootstrapping_mode
rule. This PR changes the rule to pretend to be more like a normal Rust rule.CC @cfredric