Skip to content

Tweak import macro bootstrap to trick rust analyzer aspect #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions rust/private/transitions.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,19 @@ import_macro_dep_bootstrap_transition = transition(
outputs = ["@rules_rust//rust/settings:use_real_import_macro"],
)

def _with_import_macro_bootstrapping_mode_impl(ctx):
target = ctx.attr.target[0]
return [target[rust_common.crate_info], target[rust_common.dep_info]]
def _alias_with_import_macro_bootstrapping_mode_impl(ctx):
actual = ctx.attr.actual[0]
return [actual[rust_common.crate_info], actual[rust_common.dep_info]]

with_import_macro_bootstrapping_mode = rule(
implementation = _with_import_macro_bootstrapping_mode_impl,
alias_with_import_macro_bootstrapping_mode = rule(
implementation = _alias_with_import_macro_bootstrapping_mode_impl,
doc = "Alias-like rule to build the `actual` with `use_real_import_macro` setting disabled. Not to be used outside of the import macro bootstrap.",
attrs = {
"target": attr.label(
# Using `actual` so tooling such as rust analyzer aspect traverses the target.
"actual": attr.label(
doc = "The target this alias refers to.",
cfg = import_macro_dep_bootstrap_transition,
allow_single_file = True,
mandatory = True,
executable = False,
),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
Expand Down
6 changes: 3 additions & 3 deletions util/import/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
load("//rust:defs.bzl", "rust_library", "rust_proc_macro", "rust_test")

# buildifier: disable=bzl-visibility
load("//rust/private:transitions.bzl", "with_import_macro_bootstrapping_mode")
load("//rust/private:transitions.bzl", "alias_with_import_macro_bootstrapping_mode")

with_import_macro_bootstrapping_mode(
alias_with_import_macro_bootstrapping_mode(
name = "import_macro",
target = "import_macro_impl",
actual = ":import_macro_impl",
)

rust_proc_macro(
Expand Down