Skip to content

Layout changes accessibility review #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Mar 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
2fac517
moved ToolTip next to settings icon
Jan 3, 2019
8e365d1
layout change refactor
Jan 4, 2019
461d2bb
added option to hide and resize preview window in settings
Jan 4, 2019
cf9fbca
adjusted settings panel height
Jan 4, 2019
688cd28
initial setup for mobile responsive
Jan 4, 2019
9790671
Removed separate style file for video element
Jan 4, 2019
57458ec
made fast ward and rewind btn accessible with tab and enter
Jan 4, 2019
e9b3245
cleaned up some comments
Jan 4, 2019
69b1e24
reabsed with master
Feb 2, 2019
eb53feb
Merge branch 'help-box-spike' of github.com:bbc/react-transcript-edit…
Feb 2, 2019
89a06ad
Adding some css to player control
Feb 2, 2019
ee20146
adjusted Select
Feb 19, 2019
6e53d73
Merge branch 'master' into layout-change
pietrop Feb 19, 2019
2c6a9dd
UI Tweaks
Feb 19, 2019
4e10bbd
Merge branch 'layout-change' of github.com:bbc/react-transcript-edito…
Feb 19, 2019
9c05aae
Revert "UI Tweaks"
Feb 19, 2019
ccbe700
player control fix
Feb 19, 2019
8f45a2e
fixed unsuccesful merge
Feb 19, 2019
b4ab381
moved title outside of player control
Feb 19, 2019
37de921
Removed Volume
Feb 19, 2019
8af3b78
first pass at making it responsive
Feb 19, 2019
5233619
first pass at making speakers and timecodes responsive in Timed Text …
Feb 19, 2019
a4f0ee7
fixed CSS for ipad :crossed_fingers:
Feb 20, 2019
b42d1c2
responsive text in timed text editor for ipad and mobile view
Feb 20, 2019
9b1e659
cleared out filename title overlap + updated README
Feb 22, 2019
61f8d0c
mend
Feb 22, 2019
b37d1d5
various fixes
Mar 1, 2019
361012c
+ Changing layout styles (using CSS grid)
Mar 12, 2019
723a49e
+ More style changes.
Mar 13, 2019
da64b38
Browser compatibility fixes
Mar 14, 2019
cf1ff2c
Accessibility improvements
Mar 14, 2019
89b5d16
Multiple layout/CSS fixes
Mar 15, 2019
2ca41df
Fix: breakpoint tweaks
jamesdools Mar 15, 2019
a36cfa9
Fix: shortcuts panel width
jamesdools Mar 15, 2019
16ef569
Task: Add css-modules support to eslint, clean modules
jamesdools Mar 15, 2019
a48ada9
Feature: Added stylelintrc and cleaned css modules
jamesdools Mar 15, 2019
cb9c6e0
Feature: styling to design - Making progress bar sit between controls…
jamesdools Mar 18, 2019
f5661fd
Fix: hide keyboard shortcuts icon on mobile
jamesdools Mar 18, 2019
f2e3ddd
Fix: remove mozilla focus outline on range input
jamesdools Mar 18, 2019
442a7ad
Merge branch 'master' into layout-changes-accessibility-review
jamesdools Mar 18, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
{
"parser": "babel-eslint",
"plugins": [
"react"
"react",
"css-modules"
],
"extends": [
"plugin:react/recommended"
"plugin:react/recommended",
"plugin:css-modules/recommended"
],
"env": {
"browser": true,
"jest": true
},
"rules": {
"no-unused-expressions": "error",
"no-trailing-spaces": "error",
"no-nested-ternary": "error",
"space-infix-ops": "error",
"indent": ["warn", 2],
"arrow-spacing": ["error", { "before": true, "after": true }],
"space-in-parens": [ 0, "never" ],
Expand Down Expand Up @@ -40,6 +45,7 @@
"camelcase": [ 1 ],
"no-underscore-dangle" : [0, "always"],
"keyword-spacing": ["error", { "before": true, "after": true }],
"key-spacing": ["error", { "afterColon": true }],
"newline-before-return": "error",
"space-before-blocks": "error",
"no-unused-vars": "error",
Expand Down
18 changes: 18 additions & 0 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"extends": "stylelint-config-standard",
"rules": {
"indentation": 2,
"string-quotes": "single",
"color-named": "always-where-possible",
"selector-combinator-space-after": "always",
"selector-attribute-quotes": "always",
"selector-attribute-operator-space-before": "always",
"selector-attribute-operator-space-after": "always",
"declaration-colon-space-before": "never",
"declaration-colon-space-after": "always",
"rule-empty-line-before": "always",
"media-feature-range-operator-space-before": "always",
"media-feature-range-operator-space-after": "always",
"media-feature-colon-space-after": "always"
}
}
20 changes: 12 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,18 @@ npm install @bbc/react-transcript-editor
```js
import { TranscriptEditor } from '@bbc/react-transcript-editor';

<TranscriptEditor
transcriptData=// Transcript json
mediaUrl=// string url to media file - audio or video
isEditable={true}// se to true if you want to be able to edit the text
sttJsonType={ 'bbckaldi' }// the type of STT Json transcript supported.
fileName={ this.state.fileName }// optional*
/>
```
<TranscriptEditor
transcriptData=// Transcript json
mediaUrl=// string url to media file - audio or video
isEditable={true}// se to true if you want to be able to edit the text
sttJsonType={ 'bbckaldi' }// the type of STT Json transcript supported.
handleAnalyticsEvents={ this.handleAnalyticsEvents } // optional - if you want to collect analytics events.
fileName=// optional - used for saving and retrieving local storage blob files
title=// optional - defaults to ''
ref= // optional - if you want to have access to internal functions such as retrieving content from the editor. eg to save to a server/db.
/>
```
See [`./src/index.js` demo](./src/index.js) as a more detailed example usage of the component.

_Note: `fileName` it is optional but it's needed if working with user uploaded local media in the browser, to be able to save and retrieve from local storage. For instance if you are passing a blob url to `mediaUrl` using `createObjectURL` this url is randomly re-generated on every page refresh so you wouldn't be able to restore a session, as `mediaUrl` is used as the local storage key. See demo app for more detail example of this[`./src/index.js`](./src/index.js)_

Expand Down
Loading