Skip to content

Layout changes accessibility review #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Mar 18, 2019
Merged

Layout changes accessibility review #115

merged 40 commits into from
Mar 18, 2019

Conversation

jamesdools
Copy link
Contributor

@jamesdools jamesdools commented Mar 15, 2019 •
edited
Loading

Describe what the PR does
Just continuing on from #111 and cleaning things up, with a few fixes.

State whether the PR is ready for review or whether it needs extra work
Currently a work in progress

Pietro Passarelli - News Labs and others added 30 commits January 3, 2019 19:43
moved ToolTip next to settings icon
2fac517
layout change refactor
8e365d1
added option to hide and resize preview window in settings
461d2bb
adjusted settings panel height
cf9fbca 
to accomodate for two new fields
initial setup for mobile responsive
688cd28 
leaving rest for another branch/PR tbc
Removed separate style file for video element
9790671
made fast ward and rewind btn accessible with tab and enter
57458ec
cleaned up some comments
e9b3245
reabsed with master
69b1e24
Merge branch 'help-box-spike' of github.com:bbc/react-transcript-edit…
eb53feb 
…or into layout-change
Adding some css to player control
89a06ad
adjusted Select
ee20146
@pietrop
Merge branch 'master' into layout-change
6e53d73
UI Tweaks
2c6a9dd
Merge branch 'layout-change' of github.com:bbc/react-transcript-edito…
4e10bbd 
…r into layout-change
Revert "UI Tweaks"
9c05aae 
This reverts commit 2c6a9dd.
player control fix
ccbe700
fixed unsuccesful merge
8f45a2e
moved title outside of player control
b4ab381
Removed Volume
37de921 
removed volume component and added titles tags to player controls btns
first pass at making it responsive
8af3b78 
mobile break point
first pass at making speakers and timecodes responsive in Timed Text …
5233619 
…Editor
fixed CSS for ipad 🤞
a4f0ee7
responsive text in timed text editor for ipad and mobile view
b42d1c2
cleared out filename title overlap + updated README
9b1e659
mend
61f8d0c
various fixes
b37d1d5 
eg linting, css etc.. from James' PR feedback
+ Changing layout styles (using CSS grid)
361012c
+ More style changes.
723a49e 
+ Range bar re-styled
Browser compatibility fixes
da64b38
@pietrop pietrop mentioned this pull request Mar 15, 2019
Merged
@jamesdools
Copy link
Contributor Author

Hey @ivanji, thanks so much for this! Digging the css grid work. Was just reviewing this and adding a few things, can keep you in the loop on this branch.

@jamesdools
Copy link
Contributor Author

jamesdools commented Mar 18, 2019 •
edited
Loading

Appreciate the ProgressBar styling revamp - but we've been meaning to actually have it more akin to the UX mockups produced previously (attached below).

Screen Shot 2019-03-18 at 14 27 51

We're trying to keep some visual consistency with other BBC apps out there so will go with this style for now - I've updated the CSS accordingly.

@jamesdools jamesdools merged commit ad9526f into master Mar 18, 2019
@jamesdools jamesdools deleted the layout-changes-accessibility-review branch March 18, 2019 16:01
This was referenced Mar 18, 2019
Closed
Closed
@ivanji
Copy link

ivanji commented Mar 19, 2019

Appreciate the ProgressBar styling revamp - but we've been meaning to actually have it more akin to the UX mockups produced previously (attached below).

Screen Shot 2019-03-18 at 14 27 51

We're trying to keep some visual consistency with other BBC apps out there so will go with this style for now - I've updated the CSS accordingly.

This looks nice! wish I had seen this mock-up before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdools @ivanji @pietrop