-
Notifications
You must be signed in to change notification settings - Fork 165
Add IBM Watson STT Json import support. #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IBM Watson STT Json import support. #60
Conversation
That's great, thanks @AndrewDAnderson I guess you meant to write STT (Speech To Text) and not TTS (Text To Speech) in the title of the PR (?). Looks good, and thanks for adding tests! A few comments
We'll have another look and see if there's anything else, thanks |
Co-Authored-By: AndrewDAnderson <[email protected]>
Yes. Note to self: do not make public commits at 3am.
Honestly, I didn't investigate the helper function at all - I had already started writing an adapter for a project and just tweaked it a little for use here. I do have questions about why there is so much duplication of data - but I will ask those in another place.
Responded inline. Good suggestion.
Sounds good. This was just a quick attempt to get it functional - and I'm sure others would like basic IBM support, so I was pushing it out the door with plans of cleaning things up later. |
Hi @AndrewDAnderson , We just added support for Speechmatics #94 and thought might be good to wrap up the IBM one as well. Let me know |
Is your Pull Request request related to another issue in this repository ?
No.
Describe what the PR does
Adds initial support for IBM Watson TTS Json files. Working well in my limited tests, but a few things could probably be refactored for clarity. Creating EntityRanges is done from within the adapter itself, rather than being handed off to the common function for that purpose...
State whether the PR is ready for review or whether it needs extra work
Ready to be reviewed.
Additional context
N/A