-
Notifications
You must be signed in to change notification settings - Fork 165
Speechmatics adapter #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n curatePunctuation function
PR is ready for review. Added the following functionality: -Speechmatics transcripts can now be loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Looks good, as agreed, you can leave grouping the text by speaker segments for another PR. closes #38 |
Hi @pietrop
Diarization is always provided by their cloud service by default and it does not cost extra. But it can be disabled by an argument. Maybe we should check for this in the next pr, good point. |
Yes I think it might be good to make it optional. ( in separate PR) Eg In BBC Kaldi adapter because speaker diarization is a separate optional attribute, what the adapter does is to check if the segments have been provided or not. I reckon this might be a good approach as could make the component adapter a bit more flexible. Eg someone wants to use it in a context where they already have run transcriptions through STT but didn’t think of getting the speaker diarization info etc.. |
Hello, I would like to ask about the speechmatics adapter. I believe the json that speechmatics is returning these days might well be different to what this adapter was written for? It is erroring straight away on tmpWords = curatePunctuation(speechmaticsJson.words); because speechmatics json does not return a "words" key. I am presuming the best way would be for me to pre-filter the json I am getting back with its array of "alternatives", and create a "word" key? |
Hello, const curatePunctuation = (words) => { Also, this index.js file is presumably created by the minified code in the npm module. Is there any way of accessing this, to make logs/edits? Sorry for the newbie questions. |
Is your Pull Request request related to another issue in this repository ?
This is related to #38.
Describe what the PR does
Adds a STT adapter for speechmatics.
State whether the PR is ready for review or whether it needs extra work
Tests are not implemented yet.
Additional context
Added sample transcript from speechmatics of the Demo TED Talk.