help-box-spike: moved ToolTip next to settings icon #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
Also see this note for some possible future work outside of the scope of this PR https://github.com/bbc/react-transcript-editor/projects/1#card-16169755 |
Contributor
Author
|
disregarded in favour of #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #65 look good, but thought it might had been easier to show my suggestions then describe it etc..
How Does this worknext to settings and keyboard shortcuts, this saves the extra line inTimedTextEditor.MediaPlayer/PlayerControlsarea, changed it to background colour of the keyboard shortcuts, better colour scheme match, readability, consistency etc..ToolTipcomponent has a list of CSS properties it takes as props, might be good to make use of those as much as possible and add extras only when there might be shortcomings.Let me know what you think