Skip to content

help-box-spike: moved ToolTip next to settings icon #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pietrop
Copy link
Contributor

@pietrop pietrop commented Jan 3, 2019

I think #65 look good, but thought it might had been easier to show my suggestions then describe it etc..

screen shot 2019-01-03 at 19 42 09

  • moved the How Does this work next to settings and keyboard shortcuts, this saves the extra line in TimedTextEditor.
  • because after moving the tooltip the black background didn't quiet work with the background of the MediaPlayer / PlayerControls area, changed it to background colour of the keyboard shortcuts, better colour scheme match, readability, consistency etc..
  • moved some of the CSS properties to the props of the component.
  • as refactor, to keep things tidy, I've noticed that the ToolTip component has a list of CSS properties it takes as props, might be good to make use of those as much as possible and add extras only when there might be shortcomings.

Let me know what you think

@pietrop pietrop requested a review from jamesdools January 3, 2019 18:49
@pietrop pietrop mentioned this pull request Jan 3, 2019
@pietrop
Copy link
Contributor Author

pietrop commented Jan 3, 2019

Also see this note for some possible future work outside of the scope of this PR https://github.com/bbc/react-transcript-editor/projects/1#card-16169755

@pietrop
Copy link
Contributor Author

pietrop commented Jan 4, 2019

disregarded in favour of #65

@pietrop pietrop closed this Jan 4, 2019
@pietrop pietrop deleted the help-box-spike branch January 18, 2019 16:44
@pietrop pietrop mentioned this pull request Feb 2, 2019
4 tasks
@pietrop pietrop restored the help-box-spike branch February 2, 2019 19:38
@jamesdools jamesdools deleted the help-box-spike branch March 15, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant