Remove unnecessary branch in query iteration #12844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TableRowasCasting #10811,Bevy usesassertin the hot path of iteration. Thefor_eachmethod has an assert in the outer loop to help the compiler remove unnecessary branching in the internal loop.forstyle iterations do not receive the same treatment. it still have a branch check in the internal loop, which could potentially hurt performance.Solution
TableRow::from_u32instead ofTableRow::from_usizeto avoid unnecessary branch.Before
After ----------------------------------------------------------------------------