Skip to content

Remove unnecessary branch in query iteration #12844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james7132 merged 3 commits into from
Apr 2, 2024
Merged

Remove unnecessary branch in query iteration #12844

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cff0ed
u32
re0312 Apr 2, 2024
a59948d
dbg assert
re0312 Apr 2, 2024
12211ea
table id
re0312 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_ecs/src/query/iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ impl<'w, 's, D: QueryData, F: QueryFilter> QueryIterationCursor<'w, 's, D, F> {
// SAFETY: set_table was called prior.
// `current_row` is a table row in range of the current table, because if it was not, then the above would have been executed.
let entity = unsafe { self.table_entities.get_unchecked(self.current_row) };
let row = TableRow::from_usize(self.current_row);
let row = TableRow::from_u32(self.current_row as u32);
if !F::filter_fetch(&mut self.filter, *entity, row) {
self.current_row += 1;
continue;
Expand Down