Freecam example #21477
Merged
Freecam example #21477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
janis-bhm
added
C-Examples
Contributor
|
Over all this looks solid to me, however here are a few things I noticed while testing this out: Opening this example, I am familiar with bevy's camera controls, but I think it would be useful to have the UI tell the user which keys manipulate the camera; Currently this only shows how to change the sensitivity and friction at runtime, but there are more knobs to turn on the fly cam. Personally, I think at least enabling and disabling the cam could be demonstrated, as well as mentioning |
Contributor
Author
|
Implemented your suggestions! |
janis-bhm
approved these changes
Oct 9, 2025
alice-i-cecile
approved these changes
Oct 9, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Awesome, this is pretty much exactly what I was hoping for. Thanks!
alice-i-cecile
added
S-Ready-For-Final-Review
This was referenced Oct 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…is disabled (#21485) # Objective Fixes #21482 ## Solution Before exiting the system when the controller is disabled, check if either of the cursor grab flags are set and ungrab any windows if so. Note: I think it's a bit strange that the camera un-grabs every window, not just the one with focus, but I've just copied this behaviour from further down in the function. In this case, it might be more correct to do this anyway, since the controller might be disabled when the respective window isn't focused. ## Testing I used #21477 to test this
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective Addresses bevyengine#21467. ## Solution Adds the "free_cam_controller" example, that contains a simple scene with a camera controlled by the FreeCamPlugin. the code explains how to change the settings in the FreeCam component and the example provides bindings to change sensitivity and friction live. ## Testing `cargo run --example free_cam_controller --features="free_cam"` As this is my first contribution to the project, please let me know about any problems. --------- Co-authored-by: Alice Cecile <[email protected]>
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
…is disabled (bevyengine#21485) # Objective Fixes bevyengine#21482 ## Solution Before exiting the system when the controller is disabled, check if either of the cursor grab flags are set and ungrab any windows if so. Note: I think it's a bit strange that the camera un-grabs every window, not just the one with focus, but I've just copied this behaviour from further down in the function. In this case, it might be more correct to do this anyway, since the controller might be disabled when the respective window isn't focused. ## Testing I used bevyengine#21477 to test this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Addresses #21467.
Solution
Adds the "free_cam_controller" example, that contains a simple scene with a camera controlled by the FreeCamPlugin. the code explains how to change the settings in the FreeCam component and the example provides bindings to change sensitivity and friction live.
Testing
cargo run --example free_cam_controller --features="free_cam"As this is my first contribution to the project, please let me know about any problems.