-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add CLI #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CLI #19
Conversation
checks individual filenames
Adds FileTree class to walk through supplied directory
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 93.19% 88.64% -4.56%
==========================================
Files 3 7 +4
Lines 191 317 +126
Branches 21 35 +14
==========================================
+ Hits 178 281 +103
- Misses 5 22 +17
- Partials 8 14 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a750b0f
to
0af2d62
Compare
653fda4
to
00f1936
Compare
Awesome! I've done a little patching up of the For testing the CLI, I wasn't entirely sure how best to go about it, so I spent a bit of time figuring it out and pushed it directly. It's quick and dirty, we'll probably want to clean it up some. We shouldn't worry about the 3.8 failures. 3.8 is end-of-life, so I'll make a separate PR removing it and adding testing on 3.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, here are some suggestions.
Notes from meeting:
|
I got a chance to work on this, and so added the features discussed previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One small suggestion.
This takes the
FileTree
implementation from #2 and uses it as part of a CLI.I've copied over the tests for the files.types module but can't seem to get them to run. They just skip every time, I suspect I am missing something there.
Also guidance on implementing tests for the CLI itself would be greatly appreciated.
Cheers!