-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Create validation context classes from schema.meta.context #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
==========================================
- Coverage 93.19% 87.05% -6.15%
==========================================
Files 3 11 +8
Lines 191 448 +257
Branches 21 54 +33
==========================================
+ Hits 178 390 +212
- Misses 5 38 +33
- Partials 8 20 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9bd5cec
to
684e753
Compare
3c9267c
to
bfb3e11
Compare
checks individual filenames
Adds FileTree class to walk through supplied directory
… be inspected for history
Starting to think about how to write a Python validator that builds from the schema, rather than replicating the schema. Here's some bits that make it easy to generate structured classes for the validation context (
schema.meta.context.context
) based on either the bidsschematools schema or a schema loaded from JSON.So far I have attrs classes that populate the context. It's unclear if it's worth doing something similar with the whole schema, which would be much more involved (patternProperties, additionalProperties, and the like).