AsyncIterator API for Result consumption #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.4-async-iterable
branch
from
09a5c7a to
e26bab0
Compare
bigmontz
commented
Aug 5, 2021
Comment on lines
+1315
to
+1325
| const session = driver.session() | ||
| try { | ||
| const result = session.run('UNWIND RANGE(0, 10) AS x RETURN x') | ||
| const xs = [] | ||
| for await (const record of result) { | ||
| xs.push(record.get('x').toInt()) | ||
| } | ||
| expect(xs).toEqual([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]) | ||
| } finally { | ||
| await session.close() | ||
| } |
bigmontz
force-pushed
the
4.4-introducing-lerna
branch
2 times, most recently
from
78ef05c to
d929ea7
Compare
|
Replace by neo4j#831 |
bigmontz
pushed a commit
that referenced
this pull request
May 17, 2023
Revert changes in the `userAgent`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current driver implementation has only two options for record consumption, the default async/promise api and the reactive api.
In the async side, there is no simple way to interact over the results before consuming all the data stream and back-pressure the consumption. Meanwhile in the reactive, the back-pressure is implemented but this api usage depends on the knowledge of reactive programming and
RxJS. Another issue with our current reactive implementation is not having the way to configure the back-pressure or pause the stream consumption.The introduction of the Async Iterator is part of a group of improvements to make the driver more idiomatic and memory efficient.