AsyncIterator API for Result consumption #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
commented
Dec 28, 2021
Comment on lines
+1519
to
+1529
| const session = driver.session() | ||
| try { | ||
| const result = session.run('UNWIND RANGE(0, 10) AS x RETURN x') | ||
| const xs = [] | ||
| for await (const record of result) { | ||
| xs.push(record.get('x').toInt()) | ||
| } | ||
| expect(xs).toEqual([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]) | ||
| } finally { | ||
| await session.close() | ||
| } |
bigmontz
added
work in progress
5.0
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
from
83fff10 to
1c97865
Compare
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
6 times, most recently
from
70bc926 to
73bea11
Compare
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
4 times, most recently
from
6665c57 to
7f008e6
Compare
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
from
7f008e6 to
efc064d
Compare
Summary was not available with the correct information after the result being consumed. This fix, solve this issue by wrap the summary with the same treatment subscribe and then have on complete. This change also introduce a cache for capturing the last summary the stream complete, this way the summary function could be called after the results get consumed. PS: The same fixes were applied to keys()
…tPullMode to setExplicityPull
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
from
ba89fe3 to
1d87e11
Compare
bigmontz
force-pushed
the
5.0-async-iterator-api
branch
from
1d87e11 to
1078485
Compare
This error happens in newer Nodejs versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current driver implementation has only two options for record consumption, the default async/promise api and the reactive api.
In the async side, there is no simple way to interact over the results before consuming all the data stream and back-pressure the consumption. Meanwhile in the reactive, the back-pressure is implemented but this api usage depends on the knowledge of reactive programming and
RxJS. Another issue with our current reactive implementation is not having the way to configure the back-pressure or pause the stream consumption.The introduction of the Async Iterator is part of a group of improvements to make the driver more idiomatic and memory efficient.