Fixed bug where program button did not enable for "from file" flashing in bootloader dialog#769
Merged
Fixed bug where program button did not enable for "from file" flashing in bootloader dialog#769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where the program button in the bootloader dialog did not enable when trying to flash from the "from file" tab. If the user added a file the program button did not enable, but it was still possible to flash by selecting a platform in the first tab and then going back to the "from file" tab. Now, it becomes enabled based on what is selected in each tab (expected behavior).