Skip to content

Fixed bug where program button did not enable for "from file" flashing in bootloader dialog #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enyanil merged 2 commits into from
Jan 19, 2026
Merged

Fixed bug where program button did not enable for "from file" flashing in bootloader dialog #769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60395c
Fixed bug where program button did not enable for from file flashing …
enyanil Jan 19, 2026
ff3fc49
Removed whitespace
enyanil Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions src/cfclient/ui/dialogs/bootloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def __init__(self, helper, *args):
self.programButton.clicked.connect(self.programAction)
self.coldBootButton.clicked.connect(self.initiateColdboot)
self.resetButton.clicked.connect(self.resetCopter)
self.sourceTab.currentChanged.connect(self._update_program_button_state)

self._helper.connectivity_manager.register_ui_elements(
ConnectivityManager.UiElementsContainer(
Expand Down Expand Up @@ -313,21 +314,38 @@ def _populate_firmware_dropdown(self, releases):
self.firmwareDropdown.setSizeAdjustPolicy(QtWidgets.QComboBox.SizeAdjustPolicy.AdjustToContents)
self._update_firmware_dropdown(True)

def _has_selected_file(self) -> bool:
return bool(self.imagePathLine.text())

def _update_program_button_state(self):
any_checked = any(button.isChecked() for button in self._platform_filter_checkboxes)
is_connected = self._state in [
is_connected = self._state in (
self.UIState.COLD_CONNECTED,
self.UIState.FW_CONNECTED
]

self.programButton.setEnabled(any_checked and is_connected)
)

if not is_connected:
self.programButton.setEnabled(False)
self.programButton.setToolTip("Connect your device before programming.")
elif not any_checked:
self.programButton.setToolTip("Select a platform before programming.")
return

current_tab = self.sourceTab.currentWidget()

if current_tab == self.tabFromFile:
has_file = bool(self.imagePathLine.text())
self.programButton.setEnabled(has_file)

self.programButton.setToolTip(
"" if has_file else "Choose a firmware file to program."
)
else:
self.programButton.setToolTip("")
any_platform_checked = any(
button.isChecked() for button in self._platform_filter_checkboxes
)

self.programButton.setEnabled(any_platform_checked)
self.programButton.setToolTip(
"" if any_platform_checked else "Select a platform before programming."
)

def _update_firmware_dropdown(self, active: bool):
if active:
Expand Down Expand Up @@ -392,6 +410,7 @@ def pathBrowse(self):

if filename.endswith('.zip'):
self.imagePathLine.setText(filename)
self._update_program_button_state()
else:
msgBox = QtWidgets.QMessageBox()
msgBox.setText("Wrong file extention. Must be .zip.")
Expand Down