-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[bitnami/mastodon] replace all instances of JupyterHub with Mastodon in values.yaml #20900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rHub with Mastodon Signed-off-by: JesseBot <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: jessebot <[email protected]>
FraPazGal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these typos @jessebot! Could you actually remove the chart version bump? Given this is just a cosmetic change affecting documentation I don't think we should release a new chart's version, which users will need to update to.
Signed-off-by: JesseBot <[email protected]>
|
@FraPazGal sure, no problem, I have done this. Let me know if there's anything else I can help with :) |
FraPazGal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done @jessebot, thanks again for the contribution!
Description of the change
This replaces all instances of JupyterHub with Mastodon.
Benefits
This makes the comments in the values.yaml and the README docs more clear. I believe this was just a copy paste cleanup issue. No biggie.
Possible drawbacks
none that I can think of
Applicable issues
no issues that I see immediately
Additional information
let me know if you'd like me to remove the Chart.yaml version bump
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm