Skip to content

Conversation

@jessebot
Copy link
Contributor

@jessebot jessebot commented Nov 11, 2023

Description of the change

This replaces all instances of JupyterHub with Mastodon.

Benefits

This makes the comments in the values.yaml and the README docs more clear. I believe this was just a copy paste cleanup issue. No biggie.

Possible drawbacks

none that I can think of

Applicable issues

no issues that I see immediately

Additional information

let me know if you'd like me to remove the Chart.yaml version bump

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label Nov 11, 2023
@jessebot jessebot marked this pull request as ready for review November 11, 2023 08:14
@carrodher carrodher added the verify Execute verification workflow for these changes label Nov 13, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Nov 13, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar November 13, 2023 07:29
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these typos @jessebot! Could you actually remove the chart version bump? Given this is just a cosmetic change affecting documentation I don't think we should release a new chart's version, which users will need to update to.

@jessebot jessebot requested a review from FraPazGal November 17, 2023 11:59
@jessebot
Copy link
Contributor Author

jessebot commented Nov 17, 2023

@FraPazGal sure, no problem, I have done this. Let me know if there's anything else I can help with :)

Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done @jessebot, thanks again for the contribution!

@FraPazGal FraPazGal merged commit 9fd797d into bitnami:main Nov 21, 2023
@jessebot jessebot deleted the patch-1 branch November 21, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mastodon solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants