Skip to content

Conversation

@jessebot
Copy link
Contributor

Description of the change

This fixes the if conditional for extraVolumes in in the init-job.yaml to check for initJob.extraVolumes as there is currently no extraVolumes parameter. This also fixes the indentation for extraVolumes, as it was off by a couple of spaces.

Benefits

Now you can use extra volumes for the init job, which will fix the error when you try to apply the helm chart templated manifests, because only volume_Mounts_ were templated. For instance in Argo CD, if you have extra volumes and extra volume mounts for the init job, you get:

one or more objects failed to apply, reason: Job.batch "mastodon-init" is invalid: [spec.template.spec.containers[0].volumeMounts[1].name

Possible drawbacks

don't believe there are any, as this is a simple bug fix

Applicable issues

none at this moment, I don't think

Additional information

none that I can think of

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@CeliaGMqrz
Copy link
Contributor

Hi @jessebot

Sorry for my late response.

Thanks for your contribution! Could you update the chart version?

version: 3.2.4

@jessebot
Copy link
Contributor Author

Hi @jessebot

Sorry for my late response.

Thanks for your contribution! Could you update the chart version?

version: 3.2.4

no problem at all! sorry for my mine as well :)

Copy link
Contributor

@CeliaGMqrz CeliaGMqrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@CeliaGMqrz CeliaGMqrz merged commit 571bb92 into bitnami:main Nov 21, 2023
@jessebot jessebot deleted the fix-init-job-extra-volumes branch November 21, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mastodon solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants