-
Notifications
You must be signed in to change notification settings - Fork 1.2k
.npmignores / reducing install bloat #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 cc @4ver |
👍 |
2 similar comments
👍 |
👍 |
start pushing the merge requests for this |
Those sizes are in bytes:
This doesn't seem worth optimizing. In fact, if the biggest dependency is just 13 kilobytes, it sounds like we're doing really really well. I suspect the slowness of an install has more to do with the latency of round-trips to the registry for each dependency. |
If the issue is size on disk after unpacking, 1) disk is pretty cheap 2) you can use symlinks if you've got lots of browserify copies of the same files floating around 3) you can |
I'm also not saying the slowness problem isn't real, but I think the best place to solve it will be in the npm client and registry to reduce the number of round-trips, since the size of the payload seems rather small. |
I could be wrong, but I think this issue is more about stuff like For example, here's Disk Inventory X output on the Here are the top offending modules in terms of on-disk usage: edit forgot to add, my opinion is these large test files should get added to |
On-disk size is very misleading since everything under
Ignoring the test directory on a 13k package seems pointless but slimming down acorn seems reasonable. |
looks like acorn will be ignoring tests soon |
@mattdesl Without the acorn tests the size should drop ~2MB acornjs/acorn#211. Also from browserify v8 to v9, you should've seen another ~1MB drop ForbesLindesay/umd#20 |
A fresh install of browserify produces around 26.6 mb of bloat. Most of it is coming from tests, and tests of dependencies. Not a big deal for a global install, but when you are using browserify as a local dependency for WebGL/DOM testing across several dozens of modules, it starts to add up.
Some of the heavy hitters, sorted from lowest to highest in filesize:
I could start submitting PRs for some of these, as they are easy changes.
The text was updated successfully, but these errors were encountered: