Skip to content

Add files entry to package.json. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jamestalmage
Copy link

Removes unnecessary files from the deployed package.

Deploying unnecessary files impacts the performance of npm install for everyone.

See: https://github.com/insin/package-config-checker

Removes unnecessary files from the deployed package.

Deploying unnecessary files impacts the performance of `npm install` for everyone.

See: https://github.com/insin/package-config-checker
@feross
Copy link
Owner

feross commented May 4, 2016

I personally don't think it's a good idea to ignore the test/ folder. That's documentation for the module that will now be missing when you're offline and need to look inside node_modules/ for the docs.

Ignoring huge test files is a good idea, but ignoring a few text files won't make a meaningful difference. npm install is primarily slow because of latency and roundtrips, in my experience. I don't think this is the right tradeoff.

Previous discussions:

nodejs/readable-stream#100
rvagg/through2#36
browserify/browserify#1093
browserify/sha.js#5
feross/string-to-stream#1
beatgammit/base64-js#16
mafintosh/csv-parser#43
feross/buffer#98

@feross feross closed this May 4, 2016
@jamestalmage
Copy link
Author

Certainly .travis.yml and .zuul are not providing any value.

@feross
Copy link
Owner

feross commented May 4, 2016

Sure thing. Feel free to add an .npmignore file that ignores those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants